From a2de34720d984669499e981b640cde050c2a4dfa Mon Sep 17 00:00:00 2001 From: Michael Wright Date: Sun, 5 Jun 2022 07:28:28 +0200 Subject: [PATCH] needless_late_init refactoring Remove the unneeded wrapping and unwrapping in suggestion creation. Collecting to Option> only returns None if one of the elements is None and that is never the case here. --- clippy_lints/src/needless_late_init.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clippy_lints/src/needless_late_init.rs b/clippy_lints/src/needless_late_init.rs index 5e97c606e21..4154c71b428 100644 --- a/clippy_lints/src/needless_late_init.rs +++ b/clippy_lints/src/needless_late_init.rs @@ -191,8 +191,8 @@ fn assignment_suggestions<'tcx>( assignment.rhs_span.shrink_to_hi().with_hi(assignment.span.hi()), ] }) - .map(|span| Some((span, String::new()))) - .collect::>>()?; + .map(|span| (span, String::new())) + .collect::>(); match suggestions.len() { // All of `exprs` are never types