mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rollup merge of #108449 - fee1-dead-contrib:do_not_lint_unresolved, r=compiler-errors

Browse Source 
Do not lint ineffective unstable trait impl for unresolved trait
This commit is contained in:
Matthias Krüger 2023-02-26 00:46:28 +01:00 committed by GitHub
commit a223ff7cea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
compiler/rustc_passes/src/stability.rs
View File

@ -748,7 +748,10 @@ fn visit_item(&mut self, item: &'tcx hir::Item<'tcx>) {
let mut c = CheckTraitImplStable { tcx: self.tcx, fully_stable: true };
c.visit_ty(self_ty);
c.visit_trait_ref(t);
if c.fully_stable {
// do not lint when the trait isn't resolved, since resolution error should
// be fixed first
if t.path.res != Res::Err && c.fully_stable {
self.tcx.struct_span_lint_hir(
INEFFECTIVE_UNSTABLE_TRAIT_IMPL,
item.hir_id(),

8
tests/ui/stability-attribute/unresolved_stability_lint.rs Normal file
View File

@ -0,0 +1,8 @@
#![feature(staged_api)]
#![stable(feature = "uwu", since = "1.0.0")]
#[unstable(feature = "foo", issue = "none")]
impl Foo for () {}
//~^ ERROR cannot find trait `Foo` in this scope
fn main() {}

9
tests/ui/stability-attribute/unresolved_stability_lint.stderr Normal file
View File

@ -0,0 +1,9 @@
error[E0405]: cannot find trait `Foo` in this scope
--> $DIR/unresolved_stability_lint.rs:5:6
|
LL | impl Foo for () {}
| ^^^ not found in this scope
error: aborting due to previous error
For more information about this error, try `rustc --explain E0405`.