mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Allow ascii whitespace char for doc aliases

Browse Source
This commit is contained in:
Guillaume Gomez 2020-10-05 14:00:00 +02:00
parent efbaa41306
commit a215151cd3
5 changed files with 7 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
compiler/rustc_passes/src/check_attr.rs
View File

@ -287,8 +287,9 @@ impl CheckAttrVisitor<'tcx> {
self.doc_alias_str_error(meta); self.doc_alias_str_error(meta);
return false; return false;
} }
if let Some(c) = if let Some(c) = doc_alias
doc_alias.chars().find(|&c| c == '"' || c == '\'' || c.is_whitespace()) .chars()
.find(|&c| c == '"' || c == '\'' || (c.is_whitespace() && c != ' '))
{ {
self.tcx self.tcx
.sess .sess

1
src/test/rustdoc-ui/check-doc-alias-attr.rs
View File

@ -11,6 +11,5 @@ pub struct Bar;
#[doc(alias = "\n")] //~ ERROR #[doc(alias = "\n")] //~ ERROR
#[doc(alias = " #[doc(alias = "
")] //~^ ERROR ")] //~^ ERROR
#[doc(alias = " ")] //~ ERROR
#[doc(alias = "\t")] //~ ERROR #[doc(alias = "\t")] //~ ERROR
pub struct Foo; pub struct Foo;

10
src/test/rustdoc-ui/check-doc-alias-attr.stderr
View File

@ -36,17 +36,11 @@ LL | #[doc(alias = "
LL | | ")] LL | | ")]
| |_^ | |_^
error: ' ' character isn't allowed in `#[doc(alias = "...")]`
--> $DIR/check-doc-alias-attr.rs:14:7
|
LL | #[doc(alias = " ")]
| ^^^^^^^^^^^
error: '\t' character isn't allowed in `#[doc(alias = "...")]` error: '\t' character isn't allowed in `#[doc(alias = "...")]`
--> $DIR/check-doc-alias-attr.rs:15:7 --> $DIR/check-doc-alias-attr.rs:14:7
| |
LL | #[doc(alias = "\t")] LL | #[doc(alias = "\t")]
| ^^^^^^^^^^^^ | ^^^^^^^^^^^^
error: aborting due to 8 previous errors error: aborting due to 7 previous errors

1
src/test/ui/check-doc-alias-attr.rs
View File

@ -11,6 +11,5 @@ pub struct Bar;
#[doc(alias = "\n")] //~ ERROR #[doc(alias = "\n")] //~ ERROR
#[doc(alias = " #[doc(alias = "
")] //~^ ERROR ")] //~^ ERROR
#[doc(alias = " ")] //~ ERROR
#[doc(alias = "\t")] //~ ERROR #[doc(alias = "\t")] //~ ERROR
pub struct Foo; pub struct Foo;

10
src/test/ui/check-doc-alias-attr.stderr
View File

@ -36,17 +36,11 @@ LL | #[doc(alias = "
LL | | ")] LL | | ")]
| |_^ | |_^
error: ' ' character isn't allowed in `#[doc(alias = "...")]`
--> $DIR/check-doc-alias-attr.rs:14:7
|
LL | #[doc(alias = " ")]
| ^^^^^^^^^^^
error: '\t' character isn't allowed in `#[doc(alias = "...")]` error: '\t' character isn't allowed in `#[doc(alias = "...")]`
--> $DIR/check-doc-alias-attr.rs:15:7 --> $DIR/check-doc-alias-attr.rs:14:7
| |
LL | #[doc(alias = "\t")] LL | #[doc(alias = "\t")]
| ^^^^^^^^^^^^ | ^^^^^^^^^^^^
error: aborting due to 8 previous errors error: aborting due to 7 previous errors