address review comments

This commit is contained in:
Rémy Rakic 2024-09-02 08:37:55 +00:00
parent f1df0c5fdc
commit a178559a03

View File

@ -1,42 +1,36 @@
//! Checks if selected rustc crates can be compiled on the stable channel (or a "simulation" of it). //! Checks if selected rustc crates can be compiled on the stable channel (or a "simulation" of it).
//! These crates are designed to be used by downstream users. //! These crates are designed to be used by downstream users.
use run_make_support::{cargo, run_in_tmpdir, rustc_path, source_root}; use run_make_support::{cargo, rustc_path, source_root};
fn main() { fn main() {
run_in_tmpdir(|| { // Use the stage0 beta cargo for the compilation (it shouldn't really matter which cargo we use)
// Use the stage0 beta cargo for the compilation (it shouldn't really matter which cargo we cargo()
// use) // Ensure `proc-macro2`'s nightly detection is disabled
let cargo = cargo() .env("RUSTC_STAGE", "0")
// Ensure `proc-macro2`'s nightly detection is disabled .env("RUSTC", rustc_path())
.env("RUSTC_STAGE", "0") // We want to disallow all nightly features to simulate a stable build
.env("RUSTC", rustc_path()) .env("RUSTFLAGS", "-Zallow-features=")
// We want to disallow all nightly features to simulate a stable build .arg("build")
.env("RUSTFLAGS", "-Zallow-features=") .arg("--manifest-path")
.arg("build") .arg(source_root().join("Cargo.toml"))
.arg("--manifest-path") .args(&[
.arg(source_root().join("Cargo.toml")) // Avoid depending on transitive rustc crates
.args(&[ "--no-default-features",
"--config", // Emit artifacts in this temporary directory, not in the source_root's `target` folder
r#"workspace.exclude=["library/core"]"#, "--target-dir",
// Avoid depending on transitive rustc crates "target",
"--no-default-features", ])
// Emit artifacts in this temporary directory, not in the source_root's `target` // Check that these crates can be compiled on "stable"
// folder .args(&[
"--target-dir", "-p",
".", "rustc_type_ir",
]) "-p",
// Check that these crates can be compiled on "stable" "rustc_next_trait_solver",
.args(&[ "-p",
"-p", "rustc_pattern_analysis",
"rustc_type_ir", "-p",
"-p", "rustc_lexer",
"rustc_next_trait_solver", ])
"-p", .run();
"rustc_pattern_analysis",
"-p",
"rustc_lexer",
])
.run();
});
} }