Use positive if condition for readability

2019-02-28 07:00:22 +01:00 · 2019-02-28 07:00:22 +01:00 · 9ff1340a69
commit 9ff1340a69
parent 2851f9f707
1 changed files with 9 additions and 8 deletions
--- a/doc/adding_lints.md
+++ b/doc/adding_lints.md
@ -228,14 +228,15 @@ With that we can expand our `check_fn` method to:
 ```rust
 impl EarlyLintPass for Pass {
    fn check_fn(&mut self, cx: &EarlyContext<'_>, fn_kind: FnKind<'_>, _: &FnDecl, span: Span, _: NodeId) {
-        if !is_foo_fn(fn_kind) { return; }
-        span_help_and_lint(
-            cx,
-            FOO_FUNCTIONS,
-            span,
-            "function named `foo`",
-            "consider using a more meaningful name"
-        );
+        if is_foo_fn(fn_kind) {
+            span_help_and_lint(
+                cx,
+                FOO_FUNCTIONS,
+                span,
+                "function named `foo`",
+                "consider using a more meaningful name"
+            );
+        }
    }
 }
 ```