From 9e2300015bc2a88f8f3f81d208f5dfcc1c45d31d Mon Sep 17 00:00:00 2001 From: Georg Brandl Date: Mon, 2 May 2016 07:44:21 +0200 Subject: [PATCH] lexer: do not display char confusingly in error message Current code leads to messages like "... use a \xHH escape: \u{e4}" which is confusing. The printed span already points to the offending character, which should be enough to identify the non-ASCII problem. Fixes: #29088 --- src/libsyntax/parse/lexer/mod.rs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/libsyntax/parse/lexer/mod.rs b/src/libsyntax/parse/lexer/mod.rs index 881663a056c..da62e5286d4 100644 --- a/src/libsyntax/parse/lexer/mod.rs +++ b/src/libsyntax/parse/lexer/mod.rs @@ -931,11 +931,10 @@ fn scan_char_or_byte(&mut self, _ => { if ascii_only && first_source_char > '\x7F' { let last_pos = self.last_pos; - self.err_span_char(start, - last_pos, - "byte constant must be ASCII. Use a \\xHH escape for a \ - non-ASCII byte", - first_source_char); + self.err_span_(start, + last_pos, + "byte constant must be ASCII. Use a \\xHH escape for a \ + non-ASCII byte"); return false; } }