mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Show a note when closure field is called as method

Browse Source 
Closes https://github.com/rust-lang/rust/issues/18343
This commit is contained in:
Adolfo Ochagavía 2014-10-26 16:29:27 +01:00
parent a93e9c20f2
commit 9dab88712f
1 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/librustc/middle/typeck/check/method.rs
View File

@ -223,17 +223,37 @@ pub fn report_error(fcx: &FnCtxt,
{
match error {
NoMatch(static_sources) => {
let cx = fcx.tcx();
let method_ustring = method_name.user_string(cx);
// True if the type is a struct and contains a field with
// the same name as the not-found method
let is_field = match ty::get(rcvr_ty).sty {
ty_struct(did, _) =>
ty::lookup_struct_fields(cx, did)
.iter()
.any(|f| f.name.user_string(cx) == method_ustring),
_ => false
};
fcx.type_error_message(
span,
|actual| {
format!("type `{}` does not implement any \
method in scope named `{}`",
actual,
method_name.user_string(fcx.tcx()))
method_ustring)
},
rcvr_ty,
None);
// If the method has the name of a field, give a help note
if is_field {
cx.sess.span_note(span,
format!("use `(s.{0})(...)` if you meant to call the \
function stored in the `{0}` field", method_ustring).as_slice());
}
if static_sources.len() > 0 {
fcx.tcx().sess.fileline_note(
span,