mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't call extern_crate when local crate name is the same as a dependency and we have a trait error

Browse Source
This commit is contained in:
Michael Goulet 2024-09-12 09:07:44 -04:00
parent 8d6b88b168
commit 9d5d03b7de
4 changed files with 40 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
compiler/rustc_trait_selection/src/error_reporting/traits/fulfillment_errors.rs
View File

@ -1669,6 +1669,7 @@ pub(super) fn report_similar_impl_candidates(
let name = self.tcx.crate_name(trait_def_id.krate);
let spans: Vec<_> = [trait_def_id, found_type]
.into_iter()
.filter(|def_id| def_id.krate != LOCAL_CRATE)
.filter_map(|def_id| self.tcx.extern_crate(def_id.krate))
.map(|data| {
let dependency = if data.dependency_of == LOCAL_CRATE {

1
tests/ui/typeck/auxiliary/foreign_struct_trait_unimplemented.rs Normal file
View File

@ -0,0 +1 @@
pub struct B;

15
tests/ui/typeck/foreign_struct_trait_unimplemented.rs Normal file
View File

@ -0,0 +1,15 @@
//@ aux-build:foreign_struct_trait_unimplemented.rs
extern crate foreign_struct_trait_unimplemented;
pub trait Test {}
struct A;
impl Test for A {}
fn needs_test(_: impl Test) {}
fn main() {
needs_test(foreign_struct_trait_unimplemented::B);
//~^ ERROR the trait bound `B: Test` is not satisfied
}

23
tests/ui/typeck/foreign_struct_trait_unimplemented.stderr Normal file
View File

@ -0,0 +1,23 @@
error[E0277]: the trait bound `B: Test` is not satisfied
--> $DIR/foreign_struct_trait_unimplemented.rs:13:16
|
LL | needs_test(foreign_struct_trait_unimplemented::B);
| ---------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Test` is not implemented for `B`
| |
| required by a bound introduced by this call
|
help: there are multiple different versions of crate `foreign_struct_trait_unimplemented` in the dependency graph
--> $DIR/foreign_struct_trait_unimplemented.rs:3:1
|
LL | extern crate foreign_struct_trait_unimplemented;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ one version of crate `foreign_struct_trait_unimplemented` is used here, as a direct dependency of the current crate
= help: you can use `cargo tree` to explore your dependency tree
note: required by a bound in `needs_test`
--> $DIR/foreign_struct_trait_unimplemented.rs:10:23
|
LL | fn needs_test(_: impl Test) {}
| ^^^^ required by this bound in `needs_test`
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0277`.