Fix redundant_clone
This commit is contained in:
parent
c092068996
commit
99eec3f54f
@ -307,6 +307,13 @@ fn find_stmt_assigns_to<'tcx>(
|
||||
(true, mir::Rvalue::Ref(_, _, place)) | (false, mir::Rvalue::Use(mir::Operand::Copy(place))) => {
|
||||
base_local_and_movability(cx, mir, place)
|
||||
},
|
||||
(false, mir::Rvalue::Ref(_, _, place)) => {
|
||||
if let [mir::ProjectionElem::Deref] = place.as_ref().projection {
|
||||
base_local_and_movability(cx, mir, place)
|
||||
} else {
|
||||
None
|
||||
}
|
||||
},
|
||||
_ => None,
|
||||
}
|
||||
}
|
||||
|
@ -18,11 +18,11 @@ fn main() {
|
||||
|
||||
let _s = Path::new("/a/b/").join("c");
|
||||
|
||||
let _s = Path::new("/a/b/").join("c").to_path_buf();
|
||||
let _s = Path::new("/a/b/").join("c");
|
||||
|
||||
let _s = OsString::new();
|
||||
|
||||
let _s = OsString::new().to_os_string();
|
||||
let _s = OsString::new();
|
||||
|
||||
// Check that lint level works
|
||||
#[allow(clippy::redundant_clone)]
|
||||
|
@ -59,6 +59,18 @@ note: this value is dropped without further use
|
||||
LL | let _s = Path::new("/a/b/").join("c").to_owned();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: redundant clone
|
||||
--> $DIR/redundant_clone.rs:21:42
|
||||
|
|
||||
LL | let _s = Path::new("/a/b/").join("c").to_path_buf();
|
||||
| ^^^^^^^^^^^^^^ help: remove this
|
||||
|
|
||||
note: this value is dropped without further use
|
||||
--> $DIR/redundant_clone.rs:21:14
|
||||
|
|
||||
LL | let _s = Path::new("/a/b/").join("c").to_path_buf();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: redundant clone
|
||||
--> $DIR/redundant_clone.rs:23:29
|
||||
|
|
||||
@ -71,6 +83,18 @@ note: this value is dropped without further use
|
||||
LL | let _s = OsString::new().to_owned();
|
||||
| ^^^^^^^^^^^^^^^
|
||||
|
||||
error: redundant clone
|
||||
--> $DIR/redundant_clone.rs:25:29
|
||||
|
|
||||
LL | let _s = OsString::new().to_os_string();
|
||||
| ^^^^^^^^^^^^^^^ help: remove this
|
||||
|
|
||||
note: this value is dropped without further use
|
||||
--> $DIR/redundant_clone.rs:25:14
|
||||
|
|
||||
LL | let _s = OsString::new().to_os_string();
|
||||
| ^^^^^^^^^^^^^^^
|
||||
|
||||
error: redundant clone
|
||||
--> $DIR/redundant_clone.rs:32:19
|
||||
|
|
||||
@ -131,5 +155,5 @@ note: this value is dropped without further use
|
||||
LL | let _f = f.clone();
|
||||
| ^
|
||||
|
||||
error: aborting due to 11 previous errors
|
||||
error: aborting due to 13 previous errors
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user