mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[redundant_guards]: lint empty slice checks

Browse Source
This commit is contained in:
y21 2023-11-15 19:37:36 +01:00
parent ef587d22a4
commit 998a311a13
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
clippy_lints/src/matches/redundant_guards.rs
View File

@ -106,11 +106,17 @@ pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, arms: &'tcx [Arm<'tcx>]) {
&& let Some(binding) = get_pat_binding(cx, recv, outer_arm)
{
let ty = cx.typeck_results().expr_ty(recv).peel_refs();
let slice_like = ty.is_slice() || ty.is_array();
if path.ident.name == sym!(is_empty) && ty.is_str() {
if path.ident.name == sym!(is_empty) {
// `s if s.is_empty()` becomes ""
// `arr if arr.is_empty()` becomes []
emit_redundant_guards(cx, outer_arm, if_expr.span, r#""""#.into(), &binding, None)
if ty.is_str() {
emit_redundant_guards(cx, outer_arm, if_expr.span, r#""""#.into(), &binding, None)
} else if slice_like {
emit_redundant_guards(cx, outer_arm, if_expr.span, "[]".into(), &binding, None)
}
}
}
}