From 97a3ac5b86c21cc7e478da1c90187d006ea35eb0 Mon Sep 17 00:00:00 2001 From: MarcusGrass Date: Thu, 22 Feb 2024 21:53:04 +0100 Subject: [PATCH] Allow unused_imports, and unused_import_braces on `use` --- clippy_lints/src/attrs.rs | 2 ++ tests/ui/useless_attribute.fixed | 8 ++++++++ tests/ui/useless_attribute.rs | 8 ++++++++ 3 files changed, 18 insertions(+) diff --git a/clippy_lints/src/attrs.rs b/clippy_lints/src/attrs.rs index 340111edcf1..962870663e9 100644 --- a/clippy_lints/src/attrs.rs +++ b/clippy_lints/src/attrs.rs @@ -564,6 +564,8 @@ impl<'tcx> LateLintPass<'tcx> for Attributes { || is_word(lint, sym::deprecated) || is_word(lint, sym!(unreachable_pub)) || is_word(lint, sym!(unused)) + || is_word(lint, sym!(unused_import_braces)) + || is_word(lint, sym!(unused_imports)) || extract_clippy_lint(lint).map_or(false, |s| { matches!( s.as_str(), diff --git a/tests/ui/useless_attribute.fixed b/tests/ui/useless_attribute.fixed index c7d611f36cf..7f4874b1f20 100644 --- a/tests/ui/useless_attribute.fixed +++ b/tests/ui/useless_attribute.fixed @@ -80,6 +80,14 @@ pub mod split { #[allow(clippy::single_component_path_imports)] use regex; +mod module { + pub(crate) struct Struct; +} + +#[rustfmt::skip] +#[allow(unused_import_braces, unused_imports)] +use module::{Struct}; + fn main() { test_indented_attr(); } diff --git a/tests/ui/useless_attribute.rs b/tests/ui/useless_attribute.rs index 00cfa8f5d54..d0f22db727a 100644 --- a/tests/ui/useless_attribute.rs +++ b/tests/ui/useless_attribute.rs @@ -80,6 +80,14 @@ pub mod split { #[allow(clippy::single_component_path_imports)] use regex; +mod module { + pub(crate) struct Struct; +} + +#[rustfmt::skip] +#[allow(unused_import_braces, unused_imports)] +use module::{Struct}; + fn main() { test_indented_attr(); }