mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rollup merge of #122426 - celinval:smir-fix-full, r=oli-obk

Browse Source 
Fix StableMIR `WrappingRange::is_full` computation

`WrappingRange::is_full` computation assumed that to be full the range couldn't wrap, which is not necessarily true.

For example, a range of 1..=0 is a valid representation of a full wrapping range.
This commit is contained in:
Matthias Krüger 2024-03-13 20:01:55 +01:00 committed by GitHub
commit 96a41ce513
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
compiler/stable_mir/src/abi.rs
View File

@ -383,7 +383,7 @@ impl WrappingRange {
return Err(error!("Expected size <= 128 bits, but found {} instead", size.bits())); return Err(error!("Expected size <= 128 bits, but found {} instead", size.bits()));
}; };
if self.start <= max_value && self.end <= max_value { if self.start <= max_value && self.end <= max_value {
Ok(self.start == 0 && max_value == self.end) Ok(self.start == (self.end.wrapping_add(1) & max_value))
} else { } else {
Err(error!("Range `{self:?}` out of bounds for size `{}` bits.", size.bits())) Err(error!("Range `{self:?}` out of bounds for size `{}` bits.", size.bits()))
} }