mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rollup merge of #99270 - rhysd:issue-99269, r=Mark-Simulacrum

Browse Source 
Add `#[must_use]` to `Box::from_raw`

Fixes #99269
This commit is contained in:
Yuki Okushi 2022-07-16 17:53:03 +09:00 committed by GitHub
commit 96474a718b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
library/alloc/src/boxed.rs
View File

@ -949,6 +949,7 @@ impl<T: ?Sized> Box<T> {
/// [`Layout`]: crate::Layout /// [`Layout`]: crate::Layout
#[stable(feature = "box_raw", since = "1.4.0")] #[stable(feature = "box_raw", since = "1.4.0")]
#[inline] #[inline]
#[must_use = "call `drop(from_raw(ptr))` if you intend to drop the `Box`"]
pub unsafe fn from_raw(raw: *mut T) -> Self { pub unsafe fn from_raw(raw: *mut T) -> Self {
unsafe { Self::from_raw_in(raw, Global) } unsafe { Self::from_raw_in(raw, Global) }
} }

11
src/test/ui/lint/unused/must-use-box-from-raw.rs Normal file
View File

@ -0,0 +1,11 @@
// #99269
// check-pass
#![warn(unused_must_use)]
unsafe fn free<T>(ptr: *mut T) {
Box::from_raw(ptr); //~ WARNING unused return value
}
fn main() {}

15
src/test/ui/lint/unused/must-use-box-from-raw.stderr Normal file
View File

@ -0,0 +1,15 @@
warning: unused return value of `Box::<T>::from_raw` that must be used
--> $DIR/must-use-box-from-raw.rs:8:5
|
LL | Box::from_raw(ptr);
| ^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> $DIR/must-use-box-from-raw.rs:5:9
|
LL | #![warn(unused_must_use)]
| ^^^^^^^^^^^^^^^
= note: call `drop(from_raw(ptr))` if you intend to drop the `Box`
warning: 1 warning emitted