743: Move comment r=matklad a=kjeremy

As pointed out in https://github.com/rust-analyzer/rust-analyzer/pull/738/files#r253651450

Co-authored-by: kjeremy <kjeremy@gmail.com>
This commit is contained in:
bors[bot] 2019-02-05 07:36:51 +00:00
commit 94d5d0d7e8

View File

@ -599,9 +599,6 @@ pub fn handle_code_action(
let title = source_edit.label.clone();
let edit = source_edit.try_conv_with(&world)?;
// We cannot use the 'editor.action.showReferences' command directly
// because that command requires vscode types which we convert in the handler
// on the client side.
let cmd = Command {
title,
command: "rust-analyzer.applySourceChange".to_string(),
@ -713,9 +710,10 @@ pub fn handle_code_lens_resolve(world: ServerWorld, code_lens: CodeLens) -> Resu
format!("{} implementations", locations.len())
};
return Ok(CodeLens {
range: code_lens.range,
command: Some(Command {
// We cannot use the 'editor.action.showReferences' command directly
// because that command requires vscode types which we convert in the handler
// on the client side.
let cmd = Command {
title,
command: "rust-analyzer.showReferences".into(),
arguments: Some(vec![
@ -723,7 +721,10 @@ pub fn handle_code_lens_resolve(world: ServerWorld, code_lens: CodeLens) -> Resu
to_value(code_lens.range.start).unwrap(),
to_value(locations).unwrap(),
]),
}),
};
return Ok(CodeLens {
range: code_lens.range,
command: Some(cmd),
data: None,
});
}