Also simplify macro_rules doctest code

This commit is contained in:
Urgau 2024-06-13 19:23:30 +02:00
parent ab0e72781f
commit 94c282197d
2 changed files with 6 additions and 10 deletions

View File

@ -1368,8 +1368,7 @@ pub enum NonLocalDefinitionsDiag {
depth: u32,
body_kind_descr: &'static str,
body_name: String,
help: Option<()>,
doctest_help: Option<()>,
doctest: bool,
cargo_update: Option<NonLocalDefinitionsCargoUpdateNote>,
},
}
@ -1448,8 +1447,7 @@ fn decorate_lint<'b>(self, diag: &'b mut Diag<'a, ()>) {
depth,
body_kind_descr,
body_name,
help,
doctest_help,
doctest,
cargo_update,
} => {
diag.primary_message(fluent::lint_non_local_definitions_macro_rules);
@ -1457,11 +1455,10 @@ fn decorate_lint<'b>(self, diag: &'b mut Diag<'a, ()>) {
diag.arg("body_kind_descr", body_kind_descr);
diag.arg("body_name", body_name);
if let Some(()) = help {
diag.help(fluent::lint_help);
}
if let Some(()) = doctest_help {
if doctest {
diag.help(fluent::lint_help_doctest);
} else {
diag.help(fluent::lint_help);
}
diag.note(fluent::lint_non_local);

View File

@ -304,8 +304,7 @@ fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx Item<'tcx>) {
.map(|s| s.to_ident_string())
.unwrap_or_else(|| "<unnameable>".to_string()),
cargo_update: cargo_update(),
help: (!is_at_toplevel_doctest()).then_some(()),
doctest_help: is_at_toplevel_doctest().then_some(()),
doctest: is_at_toplevel_doctest(),
},
)
}