diff --git a/src/librustc_typeck/check/wf.rs b/src/librustc_typeck/check/wf.rs index 898a5f9fe0c..b6b65093890 100644 --- a/src/librustc_typeck/check/wf.rs +++ b/src/librustc_typeck/check/wf.rs @@ -24,6 +24,7 @@ use syntax::ast_util::{local_def}; use syntax::attr; use syntax::codemap::Span; +use syntax::parse::token; use syntax::visit; use syntax::visit::Visitor; @@ -262,11 +263,64 @@ fn is_ty_param(ty: ty::Ty) -> bool { } } +fn reject_shadowing_type_parameters<'tcx>(tcx: &ty::ctxt<'tcx>, + span: Span, + generics: &ty::Generics<'tcx>) { + let impl_params = generics.types.get_slice(subst::TypeSpace).iter() + .map(|tp| tp.name).collect::>(); + + for method_param in generics.types.get_slice(subst::FnSpace).iter() { + if impl_params.contains(&method_param.name) { + tcx.sess.span_err( + span, + &*format!("type parameter `{}` shadows another type parameter of the same name", + token::get_name(method_param.name))); + } + } +} + impl<'ccx, 'tcx, 'v> Visitor<'v> for CheckTypeWellFormedVisitor<'ccx, 'tcx> { fn visit_item(&mut self, i: &ast::Item) { self.check_item_well_formed(i); visit::walk_item(self, i); } + + fn visit_fn(&mut self, + fk: visit::FnKind<'v>, fd: &'v ast::FnDecl, + b: &'v ast::Block, span: Span, id: ast::NodeId) { + match fk { + visit::FkFnBlock | visit::FkItemFn(..) => {} + visit::FkMethod(..) => { + match ty::impl_or_trait_item(self.ccx.tcx, local_def(id)) { + ty::ImplOrTraitItem::MethodTraitItem(ty_method) => { + reject_shadowing_type_parameters(self.ccx.tcx, span, &ty_method.generics) + } + _ => {} + } + } + } + visit::walk_fn(self, fk, fd, b, span) + } + + fn visit_trait_item(&mut self, t: &'v ast::TraitItem) { + match t { + &ast::TraitItem::ProvidedMethod(_) | + &ast::TraitItem::TypeTraitItem(_) => {}, + &ast::TraitItem::RequiredMethod(ref method) => { + match ty::impl_or_trait_item(self.ccx.tcx, local_def(method.id)) { + ty::ImplOrTraitItem::MethodTraitItem(ty_method) => { + reject_shadowing_type_parameters( + self.ccx.tcx, + method.span, + &ty_method.generics) + } + _ => {} + } + } + } + + visit::walk_trait_item(self, t) + } } pub struct BoundsChecker<'cx,'tcx:'cx> { diff --git a/src/libserialize/json.rs b/src/libserialize/json.rs index b7bf40a6ec5..d77540b9dde 100644 --- a/src/libserialize/json.rs +++ b/src/libserialize/json.rs @@ -1396,7 +1396,7 @@ fn ch_is(&self, c: char) -> bool { self.ch == Some(c) } - fn error(&self, reason: ErrorCode) -> Result { + fn error(&self, reason: ErrorCode) -> Result { Err(SyntaxError(reason, self.line, self.col)) } diff --git a/src/test/compile-fail/shadowed-type-parameter.rs b/src/test/compile-fail/shadowed-type-parameter.rs new file mode 100644 index 00000000000..c6286bc0a2b --- /dev/null +++ b/src/test/compile-fail/shadowed-type-parameter.rs @@ -0,0 +1,36 @@ +// Copyright 2013 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// Test that shadowed lifetimes generate an error. + +struct Foo; + +impl Foo { + fn shadow_in_method(&self) {} + //~^ ERROR type parameter `T` shadows another type parameter + + fn not_shadow_in_item(&self) { + struct Bar; // not a shadow, separate item + fn foo() {} // same + } +} + +trait Bar { + fn shadow_in_required(&self); + //~^ ERROR type parameter `T` shadows another type parameter + + fn shadow_in_provided(&self) {} + //~^ ERROR type parameter `T` shadows another type parameter + + fn not_shadow_in_required(&self); + fn not_shadow_in_provided(&self) {} +} + +fn main() {}