Add rustc_nonnull_optimization_guaranteed to Owned/Borrowed Fd/Socket
PR #94586 added support for using `rustc_nonnull_optimization_guaranteed` on values where the "null" value is the all-ones bitpattern. Now that #94586 has made it to the stage0 compiler, add `rustc_nonnull_optimization_guaranteed` to `OwnedFd`, `BorrowedFd`, `OwnedSocket`, and `BorrowedSocket`, since these types all exclude all-ones bitpatterns. This allows `Option<OwnedFd>`, `Option<BorrowedFd>`, `Option<OwnedSocket>`, and `Option<BorrowedSocket>` to be used in FFI declarations, as described in the [I/O safety RFC]. [I/O safety RFC]: https://github.com/rust-lang/rfcs/blob/master/text/3128-io-safety.md#ownedfd-and-borrowedfdfd-1
This commit is contained in:
parent
ecd44958e0
commit
90ff6fcd4e
@ -32,6 +32,7 @@ use crate::sys_common::{AsInner, FromInner, IntoInner};
|
||||
// 32-bit c_int. Below is -2, in two's complement, but that only works out
|
||||
// because c_int is 32 bits.
|
||||
#[rustc_layout_scalar_valid_range_end(0xFF_FF_FF_FE)]
|
||||
#[rustc_nonnull_optimization_guaranteed]
|
||||
#[unstable(feature = "io_safety", issue = "87074")]
|
||||
pub struct BorrowedFd<'fd> {
|
||||
fd: RawFd,
|
||||
@ -52,6 +53,7 @@ pub struct BorrowedFd<'fd> {
|
||||
// 32-bit c_int. Below is -2, in two's complement, but that only works out
|
||||
// because c_int is 32 bits.
|
||||
#[rustc_layout_scalar_valid_range_end(0xFF_FF_FF_FE)]
|
||||
#[rustc_nonnull_optimization_guaranteed]
|
||||
#[unstable(feature = "io_safety", issue = "87074")]
|
||||
pub struct OwnedFd {
|
||||
fd: RawFd,
|
||||
|
@ -32,3 +32,22 @@ fn test_fd() {
|
||||
assert_eq!(stdin_as_file.as_fd().as_raw_fd(), raw_fd);
|
||||
assert_eq!(Into::<OwnedFd>::into(stdin_as_file).into_raw_fd(), raw_fd);
|
||||
}
|
||||
|
||||
#[cfg(any(unix, target_os = "wasi"))]
|
||||
#[test]
|
||||
fn test_niche_optimizations() {
|
||||
use crate::mem::size_of;
|
||||
#[cfg(unix)]
|
||||
use crate::os::unix::io::{BorrowedFd, FromRawFd, IntoRawFd, OwnedFd, RawFd};
|
||||
#[cfg(target_os = "wasi")]
|
||||
use crate::os::wasi::io::{BorrowedFd, FromRawFd, IntoRawFd, OwnedFd, RawFd};
|
||||
|
||||
assert_eq!(size_of::<Option<OwnedFd>>(), size_of::<RawFd>());
|
||||
assert_eq!(size_of::<Option<BorrowedFd<'static>>>(), size_of::<RawFd>());
|
||||
unsafe {
|
||||
assert_eq!(OwnedFd::from_raw_fd(RawFd::MIN).into_raw_fd(), RawFd::MIN);
|
||||
assert_eq!(OwnedFd::from_raw_fd(RawFd::MAX).into_raw_fd(), RawFd::MAX);
|
||||
assert_eq!(Some(OwnedFd::from_raw_fd(RawFd::MIN)).unwrap().into_raw_fd(), RawFd::MIN);
|
||||
assert_eq!(Some(OwnedFd::from_raw_fd(RawFd::MAX)).unwrap().into_raw_fd(), RawFd::MAX);
|
||||
}
|
||||
}
|
||||
|
@ -54,3 +54,6 @@ pub use handle::*;
|
||||
pub use raw::*;
|
||||
#[unstable(feature = "io_safety", issue = "87074")]
|
||||
pub use socket::*;
|
||||
|
||||
#[cfg(test)]
|
||||
mod tests;
|
||||
|
@ -34,6 +34,7 @@ use crate::sys::cvt;
|
||||
target_pointer_width = "64",
|
||||
rustc_layout_scalar_valid_range_end(0xFF_FF_FF_FF_FF_FF_FF_FE)
|
||||
)]
|
||||
#[rustc_nonnull_optimization_guaranteed]
|
||||
#[unstable(feature = "io_safety", issue = "87074")]
|
||||
pub struct BorrowedSocket<'socket> {
|
||||
socket: RawSocket,
|
||||
@ -56,6 +57,7 @@ pub struct BorrowedSocket<'socket> {
|
||||
target_pointer_width = "64",
|
||||
rustc_layout_scalar_valid_range_end(0xFF_FF_FF_FF_FF_FF_FF_FE)
|
||||
)]
|
||||
#[rustc_nonnull_optimization_guaranteed]
|
||||
#[unstable(feature = "io_safety", issue = "87074")]
|
||||
pub struct OwnedSocket {
|
||||
socket: RawSocket,
|
||||
|
22
library/std/src/os/windows/io/tests.rs
Normal file
22
library/std/src/os/windows/io/tests.rs
Normal file
@ -0,0 +1,22 @@
|
||||
#[test]
|
||||
fn test_niche_optimizations_socket() {
|
||||
use crate::mem::size_of;
|
||||
use crate::os::windows::io::{
|
||||
BorrowedSocket, FromRawSocket, IntoRawSocket, OwnedSocket, OwnedSocket, RawSocket,
|
||||
};
|
||||
|
||||
assert_eq!(size_of::<Option<OwnedSocket>>(), size_of::<RawSocket>());
|
||||
assert_eq!(size_of::<Option<BorrowedSocket<'static>>>(), size_of::<RawSocket>(),);
|
||||
unsafe {
|
||||
assert_eq!(OwnedSocket::from_raw_socket(RawSocket::MIN).into_raw_socket(), RawSocket::MIN);
|
||||
assert_eq!(OwnedSocket::from_raw_socket(RawSocket::MAX).into_raw_socket(), RawSocket::MAX);
|
||||
assert_eq!(
|
||||
Some(OwnedSocket::from_raw_socket(RawSocket::MIN)).unwrap().into_raw_socket(),
|
||||
RawSocket::MIN
|
||||
);
|
||||
assert_eq!(
|
||||
Some(OwnedSocket::from_raw_socket(RawSocket::MAX)).unwrap().into_raw_socket(),
|
||||
RawSocket::MAX
|
||||
);
|
||||
}
|
||||
}
|
Loading…
x
Reference in New Issue
Block a user