From 90a0dd400861e296e9440e94ceac9b1d90513ca8 Mon Sep 17 00:00:00 2001 From: Tim Chevalier Date: Thu, 10 Jan 2013 15:16:15 -0800 Subject: [PATCH] core: Change XXXs into proper FIXMEs with issue numbers --- src/libcore/gc.rs | 2 +- src/libcore/pipes.rs | 2 +- src/libcore/private.rs | 3 +-- src/libcore/repr.rs | 13 +++++++------ src/libcore/stackwalk.rs | 3 ++- src/libcore/sys.rs | 2 +- src/libcore/task/spawn.rs | 2 +- src/libcore/vec.rs | 8 ++++---- 8 files changed, 18 insertions(+), 17 deletions(-) diff --git a/src/libcore/gc.rs b/src/libcore/gc.rs index bab0c710c3a..aed8ebd756f 100644 --- a/src/libcore/gc.rs +++ b/src/libcore/gc.rs @@ -344,7 +344,7 @@ pub fn cleanup_stack_for_failure() { roots.insert(*root, ()); if ptr::is_null(tydesc) { - // XXX: Destroy this box + // FIXME #4420: Destroy this box } else { rustrt::rust_call_tydesc_glue(*root, tydesc, 3 as size_t); } diff --git a/src/libcore/pipes.rs b/src/libcore/pipes.rs index 260bc7e2476..1df34b271bf 100644 --- a/src/libcore/pipes.rs +++ b/src/libcore/pipes.rs @@ -202,7 +202,7 @@ pub type Packet = { #[doc(hidden)] pub trait HasBuffer { - // XXX This should not have a trailing underscore + // FIXME #4421: This should not have a trailing underscore fn set_buffer_(b: *libc::c_void); } diff --git a/src/libcore/private.rs b/src/libcore/private.rs index 273e933f530..00087347c88 100644 --- a/src/libcore/private.rs +++ b/src/libcore/private.rs @@ -83,8 +83,7 @@ pub unsafe fn chan_from_global_ptr( let (setup1_po, setup1_ch) = pipes::stream(); let (setup2_po, setup2_ch) = pipes::stream(); - // XXX: Ugly type inference hints - let setup1_po: pipes::Port> = setup1_po; + // FIXME #4422: Ugly type inference hint let setup2_po: pipes::Port = setup2_po; do task_fn().spawn |move f, move setup1_ch, move setup2_po| { diff --git a/src/libcore/repr.rs b/src/libcore/repr.rs index 9a597bd814c..1e6aa6324aa 100644 --- a/src/libcore/repr.rs +++ b/src/libcore/repr.rs @@ -60,7 +60,8 @@ impl Writer : EscapedCharWriter { '"' => self.write_str("\\\""), '\x20'..'\x7e' => self.write_char(ch), _ => { - // XXX: This is inefficient because it requires a malloc. + // FIXME #4423: This is inefficient because it requires a + // malloc. self.write_str(char::escape_unicode(ch)) } } @@ -96,7 +97,7 @@ impl i32 : Repr { fn write_repr(writer: @Writer) { writer.write_int(self as int); } } impl i64 : Repr { - // XXX: This can lose precision. + // FIXME #4424: This can lose precision. fn write_repr(writer: @Writer) { writer.write_int(self as int); } } @@ -113,20 +114,20 @@ impl u32 : Repr { fn write_repr(writer: @Writer) { writer.write_uint(self as uint); } } impl u64 : Repr { - // XXX: This can lose precision. + // FIXME #4424: This can lose precision. fn write_repr(writer: @Writer) { writer.write_uint(self as uint); } } impl float : Repr { - // XXX: This mallocs. + // FIXME #4423: This mallocs. fn write_repr(writer: @Writer) { writer.write_str(self.to_str()); } } impl f32 : Repr { - // XXX: This mallocs. + // FIXME #4423 This mallocs. fn write_repr(writer: @Writer) { writer.write_str(self.to_str()); } } impl f64 : Repr { - // XXX: This mallocs. + // FIXME #4423: This mallocs. fn write_repr(writer: @Writer) { writer.write_str(self.to_str()); } } diff --git a/src/libcore/stackwalk.rs b/src/libcore/stackwalk.rs index f45f71104f4..0ff85e57a65 100644 --- a/src/libcore/stackwalk.rs +++ b/src/libcore/stackwalk.rs @@ -13,7 +13,8 @@ #[legacy_modes]; // tjc: remove after snapshot // NB: transitionary, de-mode-ing. -// XXX: Can't forbid this because frame_address needs a deprecated mode. +// FIXME #4425: Can't forbid this because frame_address needs a deprecated +// mode. #[allow(deprecated_mode)]; #[forbid(deprecated_pattern)]; diff --git a/src/libcore/sys.rs b/src/libcore/sys.rs index 4cefe2fea1c..9ddbbb70b0a 100644 --- a/src/libcore/sys.rs +++ b/src/libcore/sys.rs @@ -134,7 +134,7 @@ pub pure fn begin_unwind(msg: ~str, file: ~str, line: uint) -> ! { } } -// XXX: Temorary until rt::rt_fail_ goes away +// FIXME #4427: Temporary until rt::rt_fail_ goes away pub pure fn begin_unwind_(msg: *c_char, file: *c_char, line: size_t) -> ! { unsafe { gc::cleanup_stack_for_failure(); diff --git a/src/libcore/task/spawn.rs b/src/libcore/task/spawn.rs index 1ffd7fee6b1..5152c3c049c 100644 --- a/src/libcore/task/spawn.rs +++ b/src/libcore/task/spawn.rs @@ -592,7 +592,7 @@ pub fn spawn_raw(opts: TaskOpts, f: fn~()) { } // Run the box annihilator. - // XXX: Crashy. + // FIXME #4428: Crashy. // unsafe { cleanup::annihilate(); } }; diff --git a/src/libcore/vec.rs b/src/libcore/vec.rs index f84c1a9f0be..cba0ba5d71c 100644 --- a/src/libcore/vec.rs +++ b/src/libcore/vec.rs @@ -563,7 +563,7 @@ pub fn pop(v: &mut ~[T]) -> T { } let valptr = ptr::to_mut_unsafe_ptr(&mut v[ln - 1u]); unsafe { - // XXX: Should be rusti::uninit() - we don't need this zeroed + // FIXME #4204: Should be rusti::uninit() - we don't need this zeroed let mut val = rusti::init(); val <-> *valptr; raw::set_len(v, ln - 1u); @@ -636,7 +636,7 @@ pub fn push_all_move(v: &mut ~[T], rhs: ~[T]) { unsafe { do as_mut_buf(rhs) |p, len| { for uint::range(0, len) |i| { - // XXX Should be rusti::uninit() - don't need to zero + // FIXME #4204 Should be rusti::uninit() - don't need to zero let mut x = rusti::init(); x <-> *ptr::mut_offset(p, i); push(v, x); @@ -653,7 +653,7 @@ pub fn truncate(v: &mut ~[T], newlen: uint) { unsafe { // This loop is optimized out for non-drop types. for uint::range(newlen, oldlen) |i| { - // XXX Should be rusti::uninit() - don't need to zero + // FIXME #4204 Should be rusti::uninit() - don't need to zero let mut dropped = rusti::init(); dropped <-> *ptr::mut_offset(p, i); } @@ -678,7 +678,7 @@ pub fn dedup(v: &mut ~[T]) unsafe { // last_written < next_to_read < ln if *ptr::mut_offset(p, next_to_read) == *ptr::mut_offset(p, last_written) { - // XXX Should be rusti::uninit() - don't need to zero + // FIXME #4204 Should be rusti::uninit() - don't need to zero let mut dropped = rusti::init(); dropped <-> *ptr::mut_offset(p, next_to_read); } else {