mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

compiletest: make the crash test error message abit more informative

Browse Source
This commit is contained in:
Matthias Krüger 2024-06-13 17:16:28 +02:00
parent 2c243d9570
commit 8ffb5f936a
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/tools/compiletest/src/runtest.rs
View File

@ -374,11 +374,12 @@ fn run_crash_test(&self) {
// if a test does not crash, consider it an error // if a test does not crash, consider it an error
if proc_res.status.success() || matches!(proc_res.status.code(), Some(1 | 0)) { if proc_res.status.success() || matches!(proc_res.status.code(), Some(1 | 0)) {
self.fatal( self.fatal(&format!(
"test no longer crashes/triggers ICE! Please give it a mearningful name, \ "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, \
add a doc-comment to the start of the test explaining why it exists and \ add a doc-comment to the start of the test explaining why it exists and \
move it to tests/ui or wherever you see fit.", move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description \
); ensures that the corresponding ticket is auto-closed upon merge."
));
} }
} }

3
triagebot.toml
View File

@ -811,6 +811,9 @@ If appropriate, please update `CONFIG_CHANGE_HISTORY` in `src/bootstrap/src/util
[mentions."src/bootstrap/src/core/build_steps/llvm.rs"] [mentions."src/bootstrap/src/core/build_steps/llvm.rs"]
message = "This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp." message = "This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp."
[mentions."test/crashes"]
message = "This PR changes a file inside `tests/crashes`. If a crash was fixed, please move into the correspondig `ui` subdir and add 'Fixes #<issueNr>' to the pr description to autoclose the issue upon merge."
[mentions."tests/ui/deriving/deriving-all-codegen.stdout"] [mentions."tests/ui/deriving/deriving-all-codegen.stdout"]
message = "Changes to the code generated for builtin derived traits." message = "Changes to the code generated for builtin derived traits."
cc = ["@nnethercote"] cc = ["@nnethercote"]