mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix only_used_in_recursion not to lint when unused_variable

Browse Source
This commit is contained in:
Jaeyong Sung 2022-02-13 03:53:23 +09:00
parent 3a090c9f55
commit 8faa938a60
No known key found for this signature in database
GPG Key ID: 2B86898CCB2A5486
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
clippy_lints/src/only_used_in_recursion.rs
View File

@ -126,8 +126,20 @@ impl<'tcx> LateLintPass<'tcx> for OnlyUsedInRecursion {
} }
} }
let mut pre_order = FxHashMap::default();
visitor.graph.iter().for_each(|(_, next)| {
next.iter().for_each(|i| {
*pre_order.entry(*i).or_insert(0) += 1;
});
});
for (id, span, ident) in param_span { for (id, span, ident) in param_span {
if !visitor.has_side_effect.contains(&id) { // if the variable is not used in recursion, it would be marked as unused
if !visitor.has_side_effect.contains(&id)
&& *pre_order.get(&id).unwrap_or(&0) > 0
&& visitor.graph.contains_key(&id)
{
span_lint_and_sugg( span_lint_and_sugg(
cx, cx,
ONLY_USED_IN_RECURSION, ONLY_USED_IN_RECURSION,