From 8e0efbc2a78d5b723caf51f5e4732a523b4b91a0 Mon Sep 17 00:00:00 2001 From: Tetsuharu Ohzeki Date: Wed, 28 Jun 2023 03:12:42 +0900 Subject: [PATCH] editor/code: Enable `noImplicitOverride` ts option --- editors/code/src/dependencies_provider.ts | 8 ++++---- editors/code/tsconfig.json | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/editors/code/src/dependencies_provider.ts b/editors/code/src/dependencies_provider.ts index 8900aa9a5f3..d67345258ec 100644 --- a/editors/code/src/dependencies_provider.ts +++ b/editors/code/src/dependencies_provider.ts @@ -108,10 +108,10 @@ export class RustDependenciesProvider export class Dependency extends vscode.TreeItem { constructor( - public readonly label: string, + public override readonly label: string, private version: string, readonly dependencyPath: string, - public readonly collapsibleState: vscode.TreeItemCollapsibleState + public override readonly collapsibleState: vscode.TreeItemCollapsibleState ) { super(label, collapsibleState); this.resourceUri = vscode.Uri.file(dependencyPath); @@ -127,10 +127,10 @@ export class Dependency extends vscode.TreeItem { export class DependencyFile extends vscode.TreeItem { constructor( - readonly label: string, + override readonly label: string, readonly dependencyPath: string, readonly parent: Dependency | DependencyFile, - public readonly collapsibleState: vscode.TreeItemCollapsibleState + public override readonly collapsibleState: vscode.TreeItemCollapsibleState ) { super(vscode.Uri.file(dependencyPath), collapsibleState); this.id = this.resourceUri!.fsPath.toLowerCase(); diff --git a/editors/code/tsconfig.json b/editors/code/tsconfig.json index 50e3d68460a..04bd4569377 100644 --- a/editors/code/tsconfig.json +++ b/editors/code/tsconfig.json @@ -13,7 +13,6 @@ // to update typescript version without any code change. "useUnknownInCatchVariables": false, "exactOptionalPropertyTypes": false, - "noImplicitOverride": false, "noPropertyAccessFromIndexSignature": false, "noUncheckedIndexedAccess": false },