mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Auto merge of #96187 - GuillaumeGomez:potential-intra-doc-links-filtering, r=notriddle

Browse Source 
Prevent `<>` links to be interpreted for intra-doc links

As discussed in [this thread](https://github.com/rust-lang/rust/pull/96135#discussion_r852107956). As mentioned, the intra-doc RFC states that `<>` links shouldn't be potential intra-doc links:  https://rust-lang.github.io/rfcs/1946-intra-rustdoc-links.html#no-autolinks-style.

I renamed `markdown_links` into `potential_intra_doc_markdown_links` to make it more obvious what it's doing.

cc `@petrochenkov`
r? `@notriddle`
This commit is contained in:
bors 2022-04-20 21:32:01 +00:00
commit 879aff385a
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/librustdoc/html/markdown.rs
View File

@ -1312,7 +1312,19 @@ fn markdown_summary_with_limit(
let iter = Footnotes::new(HeadingLinks::new(p, None, &mut ids, HeadingOffset::H1)); let iter = Footnotes::new(HeadingLinks::new(p, None, &mut ids, HeadingOffset::H1));
for ev in iter { for ev in iter {
if let Event::Start(Tag::Link(kind, dest, _)) = ev.0 { if let Event::Start(Tag::Link(
// `<>` links cannot be intra-doc links so we skip them.
kind @ (LinkType::Inline
| LinkType::Reference
| LinkType::ReferenceUnknown
| LinkType::Collapsed
| LinkType::CollapsedUnknown
| LinkType::Shortcut
| LinkType::ShortcutUnknown),
dest,
_,
)) = ev.0
{
debug!("found link: {dest}"); debug!("found link: {dest}");
let span = span_for_link(&dest, ev.1); let span = span_for_link(&dest, ev.1);
filter_map(MarkdownLink { kind, link: dest.into_string(), range: span }) filter_map(MarkdownLink { kind, link: dest.into_string(), range: span })