From cad9cd84dc5313add7ada46c3eb8cc5c857194bc Mon Sep 17 00:00:00 2001 From: Arlo Siemsen Date: Mon, 24 Jul 2023 12:16:48 -0500 Subject: [PATCH 1/2] Update cargo --- src/tools/cargo | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/cargo b/src/tools/cargo index 1b15556767f..7ac9416d82c 160000 --- a/src/tools/cargo +++ b/src/tools/cargo @@ -1 +1 @@ -Subproject commit 1b15556767f4b78a64e868eedf4073c423f02b93 +Subproject commit 7ac9416d82cd4fc5e707c9ec3574d22dff6466e5 From ecfac686afc0222479bc129936048f0e44feb30f Mon Sep 17 00:00:00 2001 From: Arlo Siemsen Date: Mon, 24 Jul 2023 12:21:50 -0500 Subject: [PATCH 2/2] Remove credential providers from bootstrap since they are now built-in to the Cargo binary --- src/bootstrap/dist.rs | 7 ------- src/bootstrap/doc.rs | 9 --------- src/bootstrap/tool.rs | 33 --------------------------------- 3 files changed, 49 deletions(-) diff --git a/src/bootstrap/dist.rs b/src/bootstrap/dist.rs index 8c71b7f7fc2..c8750c19388 100644 --- a/src/bootstrap/dist.rs +++ b/src/bootstrap/dist.rs @@ -1085,13 +1085,6 @@ fn run(self, builder: &Builder<'_>) -> Option { tarball.add_dir(etc.join("man"), "share/man/man1"); tarball.add_legal_and_readme_to("share/doc/cargo"); - for dirent in fs::read_dir(cargo.parent().unwrap()).expect("read_dir") { - let dirent = dirent.expect("read dir entry"); - if dirent.file_name().to_str().expect("utf8").starts_with("cargo-credential-") { - tarball.add_file(&dirent.path(), "libexec", 0o755); - } - } - Some(tarball.generate()) } } diff --git a/src/bootstrap/doc.rs b/src/bootstrap/doc.rs index d4807aff4d6..2ccbf179cca 100644 --- a/src/bootstrap/doc.rs +++ b/src/bootstrap/doc.rs @@ -894,19 +894,10 @@ fn run(self, builder: &Builder<'_>) { "-p", "cargo-credential", "-p", - "cargo-credential-1password", - "-p", "mdman", // FIXME: this trips a license check in tidy. // "-p", // "resolver-tests", - // FIXME: we should probably document these, but they're different per-platform so we can't use `tool_doc`. - // "-p", - // "cargo-credential-gnome-secret", - // "-p", - // "cargo-credential-macos-keychain", - // "-p", - // "cargo-credential-wincred", ] ); tool_doc!(Tidy, "tidy", "src/tools/tidy", rustc_tool = false, ["-p", "tidy"]); diff --git a/src/bootstrap/tool.rs b/src/bootstrap/tool.rs index 725f864b718..e6d27757ac6 100644 --- a/src/bootstrap/tool.rs +++ b/src/bootstrap/tool.rs @@ -558,39 +558,6 @@ fn run(self, builder: &Builder<'_>) -> PathBuf { allow_features: "", }) .expect("expected to build -- essential tool"); - - let build_cred = |name, path| { - // These credential helpers are currently experimental. - // Any build failures will be ignored. - let _ = builder.ensure(ToolBuild { - compiler: self.compiler, - target: self.target, - tool: name, - mode: Mode::ToolRustc, - path, - is_optional_tool: true, - source_type: SourceType::Submodule, - extra_features: Vec::new(), - allow_features: "", - }); - }; - - if self.target.contains("windows") { - build_cred( - "cargo-credential-wincred", - "src/tools/cargo/credential/cargo-credential-wincred", - ); - } - if self.target.contains("apple-darwin") { - build_cred( - "cargo-credential-macos-keychain", - "src/tools/cargo/credential/cargo-credential-macos-keychain", - ); - } - build_cred( - "cargo-credential-1password", - "src/tools/cargo/credential/cargo-credential-1password", - ); cargo_bin_path } }