mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Auto merge of #13634 - nyurik:fix-iter-without-into, r=xFrednet,samueltardieu

Browse Source 
Cleanup code suggestion for `into_iter_without_iter`

Reorder the suggested code for the `IntoIterator` to match the ordering of the trait declaration:

```rust
impl IntoIterator for ... {
    type Item = ...;
    type IntoIter = ...;
```

changelog: none
This commit is contained in:
bors 2024-10-31 14:27:16 +00:00
commit 8568ca8c23
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clippy_lints/src/iter_without_into_iter.rs
View File

@ -247,8 +247,8 @@ fn check_impl_item(&mut self, cx: &LateContext<'_>, item: &rustc_hir::ImplItem<'
let sugg = format!( let sugg = format!(
" "
impl IntoIterator for {self_ty_snippet} {{ impl IntoIterator for {self_ty_snippet} {{
type IntoIter = {ret_ty};
type Item = {iter_ty}; type Item = {iter_ty};
type IntoIter = {ret_ty};
fn into_iter(self) -> Self::IntoIter {{ fn into_iter(self) -> Self::IntoIter {{
self.iter() self.iter()
}} }}

16
tests/ui/iter_without_into_iter.stderr
View File

@ -13,8 +13,8 @@ help: consider implementing `IntoIterator` for `&S1`
| |
LL + LL +
LL + impl IntoIterator for &S1 { LL + impl IntoIterator for &S1 {
LL + type IntoIter = std::slice::Iter<'_, u8>;
LL + type Item = &u8; LL + type Item = &u8;
LL + type IntoIter = std::slice::Iter<'_, u8>;
LL + fn into_iter(self) -> Self::IntoIter { LL + fn into_iter(self) -> Self::IntoIter {
LL + self.iter() LL + self.iter()
LL + } LL + }
@ -34,8 +34,8 @@ help: consider implementing `IntoIterator` for `&mut S1`
| |
LL + LL +
LL + impl IntoIterator for &mut S1 { LL + impl IntoIterator for &mut S1 {
LL + type IntoIter = std::slice::IterMut<'_, u8>;
LL + type Item = &mut u8; LL + type Item = &mut u8;
LL + type IntoIter = std::slice::IterMut<'_, u8>;
LL + fn into_iter(self) -> Self::IntoIter { LL + fn into_iter(self) -> Self::IntoIter {
LL + self.iter() LL + self.iter()
LL + } LL + }
@ -55,8 +55,8 @@ help: consider implementing `IntoIterator` for `&S3<'a>`
| |
LL + LL +
LL + impl IntoIterator for &S3<'a> { LL + impl IntoIterator for &S3<'a> {
LL + type IntoIter = std::slice::Iter<'_, u8>;
LL + type Item = &u8; LL + type Item = &u8;
LL + type IntoIter = std::slice::Iter<'_, u8>;
LL + fn into_iter(self) -> Self::IntoIter { LL + fn into_iter(self) -> Self::IntoIter {
LL + self.iter() LL + self.iter()
LL + } LL + }
@ -76,8 +76,8 @@ help: consider implementing `IntoIterator` for `&mut S3<'a>`
| |
LL + LL +
LL + impl IntoIterator for &mut S3<'a> { LL + impl IntoIterator for &mut S3<'a> {
LL + type IntoIter = std::slice::IterMut<'_, u8>;
LL + type Item = &mut u8; LL + type Item = &mut u8;
LL + type IntoIter = std::slice::IterMut<'_, u8>;
LL + fn into_iter(self) -> Self::IntoIter { LL + fn into_iter(self) -> Self::IntoIter {
LL + self.iter() LL + self.iter()
LL + } LL + }
@ -96,8 +96,8 @@ help: consider implementing `IntoIterator` for `&S8<T>`
| |
LL + LL +
LL + impl IntoIterator for &S8<T> { LL + impl IntoIterator for &S8<T> {
LL + type IntoIter = std::slice::Iter<'static, T>;
LL + type Item = &T; LL + type Item = &T;
LL + type IntoIter = std::slice::Iter<'static, T>;
LL + fn into_iter(self) -> Self::IntoIter { LL + fn into_iter(self) -> Self::IntoIter {
LL + self.iter() LL + self.iter()
LL + } LL + }
@ -117,8 +117,8 @@ help: consider implementing `IntoIterator` for `&S9<T>`
| |
LL + LL +
LL + impl IntoIterator for &S9<T> { LL + impl IntoIterator for &S9<T> {
LL + type IntoIter = std::slice::Iter<'_, T>;
LL + type Item = &T; LL + type Item = &T;
LL + type IntoIter = std::slice::Iter<'_, T>;
LL + fn into_iter(self) -> Self::IntoIter { LL + fn into_iter(self) -> Self::IntoIter {
LL + self.iter() LL + self.iter()
LL + } LL + }
@ -138,8 +138,8 @@ help: consider implementing `IntoIterator` for `&mut S9<T>`
| |
LL + LL +
LL + impl IntoIterator for &mut S9<T> { LL + impl IntoIterator for &mut S9<T> {
LL + type IntoIter = std::slice::IterMut<'_, T>;
LL + type Item = &mut T; LL + type Item = &mut T;
LL + type IntoIter = std::slice::IterMut<'_, T>;
LL + fn into_iter(self) -> Self::IntoIter { LL + fn into_iter(self) -> Self::IntoIter {
LL + self.iter() LL + self.iter()
LL + } LL + }
@ -162,8 +162,8 @@ help: consider implementing `IntoIterator` for `&Issue12037`
| |
LL ~ LL ~
LL + impl IntoIterator for &Issue12037 { LL + impl IntoIterator for &Issue12037 {
LL + type IntoIter = std::slice::Iter<'_, u8>;
LL + type Item = &u8; LL + type Item = &u8;
LL + type IntoIter = std::slice::Iter<'_, u8>;
LL + fn into_iter(self) -> Self::IntoIter { LL + fn into_iter(self) -> Self::IntoIter {
LL + self.iter() LL + self.iter()
LL + } LL + }