mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update the binary_asm_label message

Browse Source 
The link pointed to a closed issue. Create a new one and point the link
to it.

Also add a help message to hint what change the user could make.

Fixes: https://github.com/rust-lang/rust/issues/127821
This commit is contained in:
Trevor Gross 2024-07-18 15:12:28 -05:00
parent 9387a7523e
commit 8410348b1c
3 changed files with 21 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
compiler/rustc_lint/messages.ftl
View File

@ -403,8 +403,9 @@ lint_inner_macro_attribute_unstable = inner macro attributes are unstable
lint_invalid_asm_label_binary = avoid using labels containing only the digits `0` and `1` in inline assembly lint_invalid_asm_label_binary = avoid using labels containing only the digits `0` and `1` in inline assembly
.label = use a different label that doesn't start with `0` or `1` .label = use a different label that doesn't start with `0` or `1`
.note = an LLVM bug makes these labels ambiguous with a binary literal number .help = start numbering with `2` instead
.note = see <https://bugs.llvm.org/show_bug.cgi?id=36144> for more information .note1 = an LLVM bug makes these labels ambiguous with a binary literal number on x86
.note2 = see <https://github.com/llvm/llvm-project/issues/99547> for more information
lint_invalid_asm_label_format_arg = avoid using named labels in inline assembly lint_invalid_asm_label_format_arg = avoid using named labels in inline assembly
.help = only local labels of the form `<number>:` should be used in inline asm .help = only local labels of the form `<number>:` should be used in inline asm

4
compiler/rustc_lint/src/lints.rs
View File

@ -2066,7 +2066,9 @@ pub enum InvalidAsmLabel {
missing_precise_span: bool, missing_precise_span: bool,
}, },
#[diag(lint_invalid_asm_label_binary)] #[diag(lint_invalid_asm_label_binary)]
#[note] #[help]
#[note(lint_note1)]
#[note(lint_note2)]
Binary { Binary {
#[note(lint_invalid_asm_label_no_span)] #[note(lint_invalid_asm_label_no_span)]
missing_precise_span: bool, missing_precise_span: bool,

20
tests/ui/asm/binary_asm_labels.stderr
View File

@ -4,7 +4,9 @@ error: avoid using labels containing only the digits `0` and `1` in inline assem
LL | asm!("0: jmp 0b"); LL | asm!("0: jmp 0b");
| ^ use a different label that doesn't start with `0` or `1` | ^ use a different label that doesn't start with `0` or `1`
| |
= note: an LLVM bug makes these labels ambiguous with a binary literal number = help: start numbering with `2` instead
= note: an LLVM bug makes these labels ambiguous with a binary literal number on x86
= note: see <https://github.com/llvm/llvm-project/issues/99547> for more information
= note: `#[deny(binary_asm_labels)]` on by default = note: `#[deny(binary_asm_labels)]` on by default
error: avoid using labels containing only the digits `0` and `1` in inline assembly error: avoid using labels containing only the digits `0` and `1` in inline assembly
@ -13,7 +15,9 @@ error: avoid using labels containing only the digits `0` and `1` in inline assem
LL | asm!("1: jmp 1b"); LL | asm!("1: jmp 1b");
| ^ use a different label that doesn't start with `0` or `1` | ^ use a different label that doesn't start with `0` or `1`
| |
= note: an LLVM bug makes these labels ambiguous with a binary literal number = help: start numbering with `2` instead
= note: an LLVM bug makes these labels ambiguous with a binary literal number on x86
= note: see <https://github.com/llvm/llvm-project/issues/99547> for more information
error: avoid using labels containing only the digits `0` and `1` in inline assembly error: avoid using labels containing only the digits `0` and `1` in inline assembly
--> $DIR/binary_asm_labels.rs:13:15 --> $DIR/binary_asm_labels.rs:13:15
@ -21,7 +25,9 @@ error: avoid using labels containing only the digits `0` and `1` in inline assem
LL | asm!("10: jmp 10b"); LL | asm!("10: jmp 10b");
| ^^ use a different label that doesn't start with `0` or `1` | ^^ use a different label that doesn't start with `0` or `1`
| |
= note: an LLVM bug makes these labels ambiguous with a binary literal number = help: start numbering with `2` instead
= note: an LLVM bug makes these labels ambiguous with a binary literal number on x86
= note: see <https://github.com/llvm/llvm-project/issues/99547> for more information
error: avoid using labels containing only the digits `0` and `1` in inline assembly error: avoid using labels containing only the digits `0` and `1` in inline assembly
--> $DIR/binary_asm_labels.rs:14:15 --> $DIR/binary_asm_labels.rs:14:15
@ -29,7 +35,9 @@ error: avoid using labels containing only the digits `0` and `1` in inline assem
LL | asm!("01: jmp 01b"); LL | asm!("01: jmp 01b");
| ^^ use a different label that doesn't start with `0` or `1` | ^^ use a different label that doesn't start with `0` or `1`
| |
= note: an LLVM bug makes these labels ambiguous with a binary literal number = help: start numbering with `2` instead
= note: an LLVM bug makes these labels ambiguous with a binary literal number on x86
= note: see <https://github.com/llvm/llvm-project/issues/99547> for more information
error: avoid using labels containing only the digits `0` and `1` in inline assembly error: avoid using labels containing only the digits `0` and `1` in inline assembly
--> $DIR/binary_asm_labels.rs:15:15 --> $DIR/binary_asm_labels.rs:15:15
@ -37,7 +45,9 @@ error: avoid using labels containing only the digits `0` and `1` in inline assem
LL | asm!("1001101: jmp 1001101b"); LL | asm!("1001101: jmp 1001101b");
| ^^^^^^^ use a different label that doesn't start with `0` or `1` | ^^^^^^^ use a different label that doesn't start with `0` or `1`
| |
= note: an LLVM bug makes these labels ambiguous with a binary literal number = help: start numbering with `2` instead
= note: an LLVM bug makes these labels ambiguous with a binary literal number on x86
= note: see <https://github.com/llvm/llvm-project/issues/99547> for more information
error: aborting due to 5 previous errors error: aborting due to 5 previous errors