From 8366e3a7d59605ea2d0e681d73e8d5b48bf48e17 Mon Sep 17 00:00:00 2001 From: Dmitry Date: Mon, 10 Aug 2020 00:39:49 +0700 Subject: [PATCH] refactoring to show more clearly the import problems --- crates/ra_ide/src/completion.rs | 10 +++++----- xtask/tests/tidy.rs | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/crates/ra_ide/src/completion.rs b/crates/ra_ide/src/completion.rs index a537b68b1f1..9c33a5a43bb 100644 --- a/crates/ra_ide/src/completion.rs +++ b/crates/ra_ide/src/completion.rs @@ -21,19 +21,19 @@ mod unstable_feature_descriptor; use ra_ide_db::RootDatabase; -#[rustfmt::skip] use crate::{ completion::{ completion_context::CompletionContext, completion_item::{CompletionKind, Completions}, - - //TODO: cyclic imports caused by xtask generation, this should be better - unstable_feature_descriptor::UNSTABLE_FEATURE_DESCRIPTOR, - complete_attribute::LintCompletion, }, FilePosition, }; +//FIXME: cyclic imports caused by xtask generation, this should be better +use crate::completion::{ + complete_attribute::LintCompletion, unstable_feature_descriptor::UNSTABLE_FEATURE_DESCRIPTOR, +}; + pub use crate::completion::{ completion_config::CompletionConfig, completion_item::{CompletionItem, CompletionItemKind, CompletionScore, InsertTextFormat}, diff --git a/xtask/tests/tidy.rs b/xtask/tests/tidy.rs index 15a93b7a240..68a70da9e90 100644 --- a/xtask/tests/tidy.rs +++ b/xtask/tests/tidy.rs @@ -98,7 +98,7 @@ fn check_todo(path: &Path, text: &str) { // `ast::make`. "ast/make.rs", // The documentation in string literals may contain anything for its own purposes - "/completion/unstable_feature_descriptor.rs" + "completion/unstable_feature_descriptor.rs", ]; if need_todo.iter().any(|p| path.ends_with(p)) { return;