diff --git a/src/libsyntax/parse/parser.rs b/src/libsyntax/parse/parser.rs index 35ea06d62ca..729d0320435 100644 --- a/src/libsyntax/parse/parser.rs +++ b/src/libsyntax/parse/parser.rs @@ -2800,8 +2800,13 @@ impl Parser { let mut etc = false; let mut first = true; while *self.token != token::RBRACE { - if first { first = false; } - else { self.expect(&token::COMMA); } + if first { + first = false; + } else { + self.expect(&token::COMMA); + // accept trailing commas + if *self.token == token::RBRACE { break } + } etc = *self.token == token::UNDERSCORE || *self.token == token::DOTDOT; if *self.token == token::UNDERSCORE { diff --git a/src/test/compile-fail/issue-10392-2.rs b/src/test/compile-fail/issue-10392-2.rs new file mode 100644 index 00000000000..8d7125d7fdd --- /dev/null +++ b/src/test/compile-fail/issue-10392-2.rs @@ -0,0 +1,18 @@ +// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +struct A { foo: int } + +fn a() -> A { fail!() } + +fn main() { + let A { .., } = a(); //~ ERROR: expected `}` +} + diff --git a/src/test/compile-fail/issue-10392.rs b/src/test/compile-fail/issue-10392.rs new file mode 100644 index 00000000000..455704376d6 --- /dev/null +++ b/src/test/compile-fail/issue-10392.rs @@ -0,0 +1,17 @@ +// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +struct A { foo: int } + +fn a() -> A { fail!() } + +fn main() { + let A { , } = a(); //~ ERROR: expected ident +} diff --git a/src/test/run-pass/issue-10392.rs b/src/test/run-pass/issue-10392.rs new file mode 100644 index 00000000000..796fae7dc32 --- /dev/null +++ b/src/test/run-pass/issue-10392.rs @@ -0,0 +1,37 @@ +// Copyright 2013 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +struct A { foo: int } +struct B { a: int, b: int, c: int } + +fn mka() -> A { fail!() } +fn mkb() -> B { fail!() } + +fn test() { + let A { foo, } = mka(); + let A { + foo, + } = mka(); + + let B { a, b, c, } = mkb(); + + match mka() { + A { foo: _foo, } => {} + } + + match Some(mka()) { + Some(A { foo: _foo, }) => {} + None => {} + } +} + +pub fn main() { + if false { test() } +}