From 7ff71199df911b462800cf6bda7ac32879ba7eb1 Mon Sep 17 00:00:00 2001
From: Eduardo Broto <ebroto@tutanota.com>
Date: Thu, 21 May 2020 14:46:04 +0200
Subject: [PATCH] Address comments from PR review

---
 clippy_dev/src/new_lint.rs                             | 1 +
 tests/compile-test.rs                                  | 4 ++--
 tests/ui-cargo/cargo_common_metadata/fail/Cargo.toml   | 1 +
 tests/ui-cargo/cargo_common_metadata/pass/Cargo.toml   | 1 +
 tests/ui-cargo/multiple_crate_versions/fail/Cargo.toml | 1 +
 tests/ui-cargo/multiple_crate_versions/pass/Cargo.toml | 1 +
 tests/ui-cargo/wildcard_dependencies/fail/Cargo.toml   | 1 +
 tests/ui-cargo/wildcard_dependencies/pass/Cargo.toml   | 1 +
 8 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/clippy_dev/src/new_lint.rs b/clippy_dev/src/new_lint.rs
index 843beaf3238..80713ab569f 100644
--- a/clippy_dev/src/new_lint.rs
+++ b/clippy_dev/src/new_lint.rs
@@ -139,6 +139,7 @@ fn get_manifest_contents(lint_name: &str, hint: &str) -> String {
 [package]
 name = "{}"
 version = "0.1.0"
+publish = false
 "#,
         hint, lint_name
     )
diff --git a/tests/compile-test.rs b/tests/compile-test.rs
index 91b9c73c9d4..232b966f69a 100644
--- a/tests/compile-test.rs
+++ b/tests/compile-test.rs
@@ -147,7 +147,7 @@ fn run_tests(config: &compiletest::Config, mut tests: Vec<tester::TestDescAndFn>
         Ok(true) => {},
         Ok(false) => panic!("Some tests failed"),
         Err(e) => {
-            println!("I/O failure during tests: {:?}", e);
+            panic!("I/O failure during tests: {:?}", e);
         },
     }
 }
@@ -223,7 +223,7 @@ fn run_tests(
         Ok(true) => {},
         Ok(false) => panic!("Some tests failed"),
         Err(e) => {
-            println!("I/O failure during tests: {:?}", e);
+            panic!("I/O failure during tests: {:?}", e);
         },
     }
 }
diff --git a/tests/ui-cargo/cargo_common_metadata/fail/Cargo.toml b/tests/ui-cargo/cargo_common_metadata/fail/Cargo.toml
index 8346bf05778..c64adcf7c01 100644
--- a/tests/ui-cargo/cargo_common_metadata/fail/Cargo.toml
+++ b/tests/ui-cargo/cargo_common_metadata/fail/Cargo.toml
@@ -1,3 +1,4 @@
 [package]
 name = "cargo_common_metadata"
 version = "0.1.0"
+publish = false
diff --git a/tests/ui-cargo/cargo_common_metadata/pass/Cargo.toml b/tests/ui-cargo/cargo_common_metadata/pass/Cargo.toml
index f99c126fabf..c8233f328bb 100644
--- a/tests/ui-cargo/cargo_common_metadata/pass/Cargo.toml
+++ b/tests/ui-cargo/cargo_common_metadata/pass/Cargo.toml
@@ -1,6 +1,7 @@
 [package]
 name = "cargo_common_metadata"
 version = "0.1.0"
+publish = false
 authors = ["Random person from the Internet <someone@someplace.org>"]
 description = "A test package for the cargo_common_metadata lint"
 repository = "https://github.com/someone/cargo_common_metadata"
diff --git a/tests/ui-cargo/multiple_crate_versions/fail/Cargo.toml b/tests/ui-cargo/multiple_crate_versions/fail/Cargo.toml
index 05ffde839dc..3a94b723f3f 100644
--- a/tests/ui-cargo/multiple_crate_versions/fail/Cargo.toml
+++ b/tests/ui-cargo/multiple_crate_versions/fail/Cargo.toml
@@ -1,6 +1,7 @@
 [package]
 name = "multiple_crate_versions"
 version = "0.1.0"
+publish = false
 
 [dependencies]
 ctrlc = "=3.1.0"
diff --git a/tests/ui-cargo/multiple_crate_versions/pass/Cargo.toml b/tests/ui-cargo/multiple_crate_versions/pass/Cargo.toml
index cad32b9233f..a9b06420b33 100644
--- a/tests/ui-cargo/multiple_crate_versions/pass/Cargo.toml
+++ b/tests/ui-cargo/multiple_crate_versions/pass/Cargo.toml
@@ -1,6 +1,7 @@
 [package]
 name = "cargo_common_metadata"
 version = "0.1.0"
+publish = false
 
 [dependencies]
 regex = "1.3.7"
diff --git a/tests/ui-cargo/wildcard_dependencies/fail/Cargo.toml b/tests/ui-cargo/wildcard_dependencies/fail/Cargo.toml
index 9558dd68091..fd2a3414856 100644
--- a/tests/ui-cargo/wildcard_dependencies/fail/Cargo.toml
+++ b/tests/ui-cargo/wildcard_dependencies/fail/Cargo.toml
@@ -1,6 +1,7 @@
 [package]
 name = "wildcard_dependencies"
 version = "0.1.0"
+publish = false
 
 [dependencies]
 regex = "*"
diff --git a/tests/ui-cargo/wildcard_dependencies/pass/Cargo.toml b/tests/ui-cargo/wildcard_dependencies/pass/Cargo.toml
index 062e441622a..38cb139146e 100644
--- a/tests/ui-cargo/wildcard_dependencies/pass/Cargo.toml
+++ b/tests/ui-cargo/wildcard_dependencies/pass/Cargo.toml
@@ -1,6 +1,7 @@
 [package]
 name = "wildcard_dependencies"
 version = "0.1.0"
+publish = false
 
 [dependencies]
 regex = "1"