mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Account for unmet T: !Copy in E0277 message

Browse Source
This commit is contained in:
Esteban Küber 2024-02-29 16:30:01 +00:00
parent d89c2c569a
commit 7f97dfe700
2 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
View File

@ -4773,11 +4773,18 @@ pub(super) fn get_explanation_based_on_obligation<'tcx>(
Some(desc) => format!(" {desc}"), Some(desc) => format!(" {desc}"),
None => String::new(), None => String::new(),
}; };
format!( if let ty::ImplPolarity::Positive = trait_predicate.polarity() {
"{pre_message}the trait `{}` is not implemented for{desc} `{}`{post}", format!(
trait_predicate.print_modifiers_and_trait_path(), "{pre_message}the trait `{}` is not implemented for{desc} `{}`{post}",
tcx.short_ty_string(trait_ref.skip_binder().self_ty(), &mut None), trait_predicate.print_modifiers_and_trait_path(),
) tcx.short_ty_string(trait_ref.skip_binder().self_ty(), &mut None),
)
} else {
// "the trait bound `T: !Send` is not satisfied" reads better than "`!Send` is
// not implemented for `T`".
// FIXME: add note explaining explicit negative trait bounds.
format!("{pre_message}the trait bound `{trait_predicate}` is not satisfied{post}")
}
} }
} }

8
tests/ui/traits/negative-bounds/simple.stderr
View File

@ -2,7 +2,7 @@ error[E0277]: the trait bound `T: !Copy` is not satisfied
--> $DIR/simple.rs:10:16 --> $DIR/simple.rs:10:16
| |
LL | not_copy::<T>(); LL | not_copy::<T>();
| ^ the trait `!Copy` is not implemented for `T` | ^ the trait bound `T: !Copy` is not satisfied
| |
note: required by a bound in `not_copy` note: required by a bound in `not_copy`
--> $DIR/simple.rs:3:16 --> $DIR/simple.rs:3:16
@ -14,7 +14,7 @@ error[E0277]: the trait bound `T: !Copy` is not satisfied
--> $DIR/simple.rs:15:16 --> $DIR/simple.rs:15:16
| |
LL | not_copy::<T>(); LL | not_copy::<T>();
| ^ the trait `!Copy` is not implemented for `T` | ^ the trait bound `T: !Copy` is not satisfied
| |
note: required by a bound in `not_copy` note: required by a bound in `not_copy`
--> $DIR/simple.rs:3:16 --> $DIR/simple.rs:3:16
@ -26,7 +26,7 @@ error[E0277]: the trait bound `Copyable: !Copy` is not satisfied
--> $DIR/simple.rs:30:16 --> $DIR/simple.rs:30:16
| |
LL | not_copy::<Copyable>(); LL | not_copy::<Copyable>();
| ^^^^^^^^ the trait `!Copy` is not implemented for `Copyable` | ^^^^^^^^ the trait bound `Copyable: !Copy` is not satisfied
| |
= help: the trait `Copy` is implemented for `Copyable` = help: the trait `Copy` is implemented for `Copyable`
note: required by a bound in `not_copy` note: required by a bound in `not_copy`
@ -44,7 +44,7 @@ error[E0277]: the trait bound `NotNecessarilyCopyable: !Copy` is not satisfied
--> $DIR/simple.rs:37:16 --> $DIR/simple.rs:37:16
| |
LL | not_copy::<NotNecessarilyCopyable>(); LL | not_copy::<NotNecessarilyCopyable>();
| ^^^^^^^^^^^^^^^^^^^^^^ the trait `!Copy` is not implemented for `NotNecessarilyCopyable` | ^^^^^^^^^^^^^^^^^^^^^^ the trait bound `NotNecessarilyCopyable: !Copy` is not satisfied
| |
note: required by a bound in `not_copy` note: required by a bound in `not_copy`
--> $DIR/simple.rs:3:16 --> $DIR/simple.rs:3:16