mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rollup merge of #130793 - jieyouxu:mention-crashes-verbose, r=matthiaskrgr

Browse Source 
Mention `COMPILETEST_VERBOSE_CRASHES` on crash test failure

Fixes https://github.com/rust-lang/rust/issues/130776.

r? `@matthiaskrgr` (or compiler/bootstrap)
This commit is contained in:
Trevor Gross 2024-09-24 19:47:51 -04:00 committed by GitHub
commit 7de108277b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/tools/compiletest/src/runtest/crash.rs
View File

@ -15,10 +15,11 @@ pub(super) fn run_crash_test(&self) {
// if a test does not crash, consider it an error
if proc_res.status.success() || matches!(proc_res.status.code(), Some(1 | 0)) {
self.fatal(&format!(
"crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, \
add a doc-comment to the start of the test explaining why it exists and \
move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description \
ensures that the corresponding ticket is auto-closed upon merge."
"crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful \
name, add a doc-comment to the start of the test explaining why it exists and \
move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR \
description ensures that the corresponding ticket is auto-closed upon merge. \
If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
));
}
}