mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove redundant code for handling NULL handles on Windows.

Browse Source 
Before calling `CreateProcessW`, stdio handles are passed through
`stdio::get_handle`, which already converts NULL to
`INVALID_HANDLE_VALUE`, so we don't need extra checks for NULL after
that point.
This commit is contained in:
Dan Gohman 2022-03-02 11:48:50 -08:00
parent 7dd32469e5
commit 7ddf41c7b1
1 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
library/std/src/sys/windows/process.rs
View File

@ -309,19 +309,6 @@ impl Command {
si.hStdOutput = stdout.as_raw_handle(); si.hStdOutput = stdout.as_raw_handle();
si.hStdError = stderr.as_raw_handle(); si.hStdError = stderr.as_raw_handle();
// `CreateProcessW` fails with `ERROR_FILE_NOT_FOUND` if any of the
// stdio handles are null, so if we have null handles, set them to
// `INVALID_HANDLE_VALUE`.
if si.hStdInput.is_null() {
si.hStdInput = c::INVALID_HANDLE_VALUE;
}
if si.hStdOutput.is_null() {
si.hStdOutput = c::INVALID_HANDLE_VALUE;
}
if si.hStdError.is_null() {
si.hStdError = c::INVALID_HANDLE_VALUE;
}
let program = to_u16s(&program)?; let program = to_u16s(&program)?;
unsafe { unsafe {
cvt(c::CreateProcessW( cvt(c::CreateProcessW(