From 7dbc568325c929eeefc261532b034f904cf4d5b4 Mon Sep 17 00:00:00 2001 From: Hans Kratz Date: Tue, 3 Aug 2021 05:11:17 +0000 Subject: [PATCH] Fix va_args calling on aarch64 non-macos/ios. emit_aapcs_va_arg() emits hardcoded field indexes to access the aarch64-specific `VaListImpl` struct. Due to the removed padding those indexes have changed. --- compiler/rustc_codegen_llvm/src/va_arg.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/compiler/rustc_codegen_llvm/src/va_arg.rs b/compiler/rustc_codegen_llvm/src/va_arg.rs index c9fb09570c3..4888f7f355f 100644 --- a/compiler/rustc_codegen_llvm/src/va_arg.rs +++ b/compiler/rustc_codegen_llvm/src/va_arg.rs @@ -110,13 +110,13 @@ fn emit_aapcs_va_arg( let gr_type = target_ty.is_any_ptr() || target_ty.is_integral(); let (reg_off, reg_top_index, slot_size) = if gr_type { - let gr_offs = bx.struct_gep(va_list_ty, va_list_addr, 7); + let gr_offs = bx.struct_gep(va_list_ty, va_list_addr, 3); let nreg = (layout.size.bytes() + 7) / 8; - (gr_offs, 3, nreg * 8) + (gr_offs, 1, nreg * 8) } else { - let vr_off = bx.struct_gep(va_list_ty, va_list_addr, 9); + let vr_off = bx.struct_gep(va_list_ty, va_list_addr, 4); let nreg = (layout.size.bytes() + 15) / 16; - (vr_off, 5, nreg * 16) + (vr_off, 2, nreg * 16) }; // if the offset >= 0 then the value will be on the stack