mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Auto merge of #11448 - RalfJung:DefaultUnionRepresentation, r=blyxyas

Browse Source 
DefaultUnionRepresentation: explain why we only warn about unions with at least 2 non-ZST fields

changelog: none
This commit is contained in:
bors 2023-09-02 10:14:33 +00:00
commit 7cf96dabb7
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
clippy_lints/src/default_union_representation.rs
View File

@ -69,6 +69,9 @@ fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx Item<'tcx>) {
} }
/// Returns true if the given item is a union with at least two non-ZST fields. /// Returns true if the given item is a union with at least two non-ZST fields.
/// (ZST fields having an arbitrary offset is completely inconsequential, and
/// if there is only one field left after ignoring ZST fields then the offset
/// of that field does not matter either.)
fn is_union_with_two_non_zst_fields(cx: &LateContext<'_>, item: &Item<'_>) -> bool { fn is_union_with_two_non_zst_fields(cx: &LateContext<'_>, item: &Item<'_>) -> bool {
if let ItemKind::Union(data, _) = &item.kind { if let ItemKind::Union(data, _) = &item.kind {
data.fields().iter().filter(|f| !is_zst(cx, f.ty)).count() >= 2 data.fields().iter().filter(|f| !is_zst(cx, f.ty)).count() >= 2