From 5c31efd429e361947b7c54252145261a141c284e Mon Sep 17 00:00:00 2001 From: Ian Kronquist Date: Tue, 12 Nov 2019 16:02:02 -0800 Subject: [PATCH 1/3] Typo in literal_representation.rs Octal numbers can't have 8 in them ;) --- clippy_lints/src/literal_representation.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clippy_lints/src/literal_representation.rs b/clippy_lints/src/literal_representation.rs index 8ddd54bb7a3..6681b8e6b98 100644 --- a/clippy_lints/src/literal_representation.rs +++ b/clippy_lints/src/literal_representation.rs @@ -35,7 +35,7 @@ /// **Known problems:** /// - Recommends a signed suffix, even though the number might be too big and an unsigned /// suffix is required - /// - Does not match on `_128` since that is a valid grouping for decimal and octal numbers + /// - Does not match on `_128` since that is a valid grouping for decimal and hexadecimal numbers /// /// **Example:** /// From b13f4e4fafa59402be86f377e360cba215818f8a Mon Sep 17 00:00:00 2001 From: Ian Kronquist Date: Mon, 25 Nov 2019 16:28:46 -0800 Subject: [PATCH 2/3] Update literal_representation.rs --- clippy_lints/src/literal_representation.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clippy_lints/src/literal_representation.rs b/clippy_lints/src/literal_representation.rs index 6681b8e6b98..2d50d64fc65 100644 --- a/clippy_lints/src/literal_representation.rs +++ b/clippy_lints/src/literal_representation.rs @@ -35,7 +35,7 @@ /// **Known problems:** /// - Recommends a signed suffix, even though the number might be too big and an unsigned /// suffix is required - /// - Does not match on `_128` since that is a valid grouping for decimal and hexadecimal numbers + /// - Does not match on `_128` since that is a valid grouping for decimal numbers /// /// **Example:** /// From aef266289680ba39b41fd1e3333b572c84bc67aa Mon Sep 17 00:00:00 2001 From: Ian Kronquist Date: Mon, 25 Nov 2019 16:30:46 -0800 Subject: [PATCH 3/3] Update literal_representation.rs --- clippy_lints/src/literal_representation.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clippy_lints/src/literal_representation.rs b/clippy_lints/src/literal_representation.rs index 2d50d64fc65..eba6a4fdbb9 100644 --- a/clippy_lints/src/literal_representation.rs +++ b/clippy_lints/src/literal_representation.rs @@ -35,7 +35,7 @@ /// **Known problems:** /// - Recommends a signed suffix, even though the number might be too big and an unsigned /// suffix is required - /// - Does not match on `_128` since that is a valid grouping for decimal numbers + /// - Does not match on `_127` since that is a valid grouping for decimal and octal numbers /// /// **Example:** ///