mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Always derive from process.env when spawning a child process/shell execution

Browse Source 
This is useful when an extension (e.g. Nix Environment Selector) or launch
configuration sets one or more environment variables.

When `env` is not explicitly specified in the options passed to
`child_process.spawn()` or `vscode.ShellExecution()`, then `process.env` gets
applied automatically. But when an explicit `env` is set, it should inherit from
`process.env` rather than replace it completely.
This commit is contained in:
Alin Sinpalean 2020-05-31 13:41:52 +02:00
parent 09df51dab8
commit 771457ec5c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
editors/code/src/run.ts
View File

@ -177,7 +177,7 @@ export function createTask(spec: ra.Runnable): vscode.Task {
label: spec.label, label: spec.label,
command: spec.bin, command: spec.bin,
args: spec.extraArgs ? [...spec.args, '--', ...spec.extraArgs] : spec.args, args: spec.extraArgs ? [...spec.args, '--', ...spec.extraArgs] : spec.args,
env: spec.env, env: Object.assign({}, process.env, spec.env),
}; };
const execOption: vscode.ShellExecutionOptions = { const execOption: vscode.ShellExecutionOptions = {