Argument type for mutable with_metadata_of (#75091)
The method takes two pointer arguments: one `self` supplying the pointer value, and a second pointer supplying the metadata. The new parameter type more clearly reflects the actual requirements. The provenance of the metadata parameter is disregarded completely. Using a mutable pointer in the call site can be coerced to a const pointer while the reverse is not true. An example of the current use: ```rust // Manually taking an unsized object from a `ManuallyDrop` into another allocation. let val: &core::mem::ManuallyDrop<T> = …; let ptr = val as *const _ as *mut T; let ptr = uninit.as_ptr().with_metadata_of(ptr); ``` This could then instead be simplified to: ```rust // Manually taking an unsized object from a `ManuallyDrop` into another allocation. let val: &core::mem::ManuallyDrop<T> = …; let ptr = uninit.as_ptr().with_metadata_of(&**val); ```
This commit is contained in:
parent
b1ab3b738a
commit
71c39dea4d
@ -80,10 +80,14 @@ impl<T: ?Sized> *mut T {
|
||||
#[unstable(feature = "set_ptr_value", issue = "75091")]
|
||||
#[must_use = "returns a new pointer rather than modifying its argument"]
|
||||
#[inline]
|
||||
pub fn with_metadata_of<U>(self, mut val: *mut U) -> *mut U
|
||||
pub fn with_metadata_of<U>(self, val: *const U) -> *mut U
|
||||
where
|
||||
U: ?Sized,
|
||||
{
|
||||
// Prepare in the type system that we will replace the pointer value with a mutable
|
||||
// pointer, taking the mutable provenance from the `self` pointer.
|
||||
let mut val = val as *mut U;
|
||||
// Pointer to the pointer value within the value.
|
||||
let target = &mut val as *mut *mut U as *mut *mut u8;
|
||||
// SAFETY: In case of a thin pointer, this operations is identical
|
||||
// to a simple assignment. In case of a fat pointer, with the current
|
||||
|
Loading…
x
Reference in New Issue
Block a user