keep severity to Error & WeakWarning

This commit is contained in:
gfreezy 2018-12-24 22:48:46 +08:00
parent 17b35a7f7d
commit 70df097c89
2 changed files with 8 additions and 10 deletions

View File

@ -364,7 +364,7 @@ impl AnalysisImpl {
.map(|d| Diagnostic {
range: d.range,
message: d.msg,
severity: d.severity,
severity: Some(d.severity),
fix: None,
})
.collect::<Vec<_>>();

View File

@ -34,16 +34,14 @@ pub struct HighlightedRange {
#[derive(Debug, Copy, Clone)]
pub enum Severity {
Error,
Warning,
Information,
Hint,
WeakWarning,
}
#[derive(Debug)]
pub struct Diagnostic {
pub range: TextRange,
pub msg: String,
pub severity: Option<Severity>,
pub severity: Severity,
}
#[derive(Debug)]
@ -112,7 +110,7 @@ pub fn diagnostics(file: &SourceFileNode) -> Vec<Diagnostic> {
.map(|err| Diagnostic {
range: location_to_range(err.location()),
msg: format!("Syntax Error: {}", err),
severity: Some(Severity::Error),
severity: Severity::Error,
})
.collect();
@ -130,7 +128,7 @@ fn check_unnecessary_braces_in_use_statement(file: &SourceFileNode) -> Vec<Diagn
diagnostics.push(Diagnostic {
range: use_tree_list.syntax().range(),
msg: format!("Unnecessary braces in use statement"),
severity: Some(Severity::Warning),
severity: Severity::WeakWarning,
})
}
}
@ -252,9 +250,9 @@ fn main() {}
);
let diagnostics = check_unnecessary_braces_in_use_statement(&file);
assert_eq_dbg(
r#"[Diagnostic { range: [12; 15), msg: "Unnecessary braces in use statement", severity: Some(Warning) },
Diagnostic { range: [24; 27), msg: "Unnecessary braces in use statement", severity: Some(Warning) },
Diagnostic { range: [61; 64), msg: "Unnecessary braces in use statement", severity: Some(Warning) }]"#,
r#"[Diagnostic { range: [12; 15), msg: "Unnecessary braces in use statement", severity: WeakWarning },
Diagnostic { range: [24; 27), msg: "Unnecessary braces in use statement", severity: WeakWarning },
Diagnostic { range: [61; 64), msg: "Unnecessary braces in use statement", severity: WeakWarning }]"#,
&diagnostics,
)
}