From 6f59981a7a6beac80265a6e68236f8337ba5680d Mon Sep 17 00:00:00 2001 From: Michael Howell Date: Sat, 15 Oct 2022 11:45:27 -0700 Subject: [PATCH] rustdoc: fix Ctrl-Click on help and settings links --- src/librustdoc/html/static/js/main.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/librustdoc/html/static/js/main.js b/src/librustdoc/html/static/js/main.js index 7df6a974b88..619d4bb399e 100644 --- a/src/librustdoc/html/static/js/main.js +++ b/src/librustdoc/html/static/js/main.js @@ -201,6 +201,9 @@ function loadCss(cssFileName) { } getSettingsButton().onclick = event => { + if (event.ctrlKey || event.altKey || event.metaKey) { + return; + } addClass(getSettingsButton(), "rotate"); event.preventDefault(); // Sending request for the CSS and the JS files at the same time so it will @@ -951,7 +954,11 @@ function loadCss(cssFileName) { } else { document.querySelector(`#${HELP_BUTTON_ID} > a`).addEventListener("click", event => { const target = event.target; - if (target.tagName !== "A" || target.parentElement.id !== HELP_BUTTON_ID) { + if (target.tagName !== "A" || + target.parentElement.id !== HELP_BUTTON_ID || + event.ctrlKey || + event.altKey || + event.metaKey) { return; } event.preventDefault();