Comments only: annotate FIXMEs
This commit is contained in:
parent
dce5d6ab9c
commit
6b16325f43
@ -39,7 +39,7 @@ fn map_slices<A: copy send, B: copy send>(
|
||||
log(info, "spawning tasks");
|
||||
while base < len {
|
||||
let end = uint::min(len, base + items_per_task);
|
||||
// FIXME: why is the ::<A, ()> annotation required here?
|
||||
// FIXME: why is the ::<A, ()> annotation required here? (#2617)
|
||||
vec::unpack_slice::<A, ()>(xs) {|p, _len|
|
||||
let f = f();
|
||||
futures += [future::spawn() {|copy base|
|
||||
|
@ -9,6 +9,7 @@ import diagnostic::span_handler;
|
||||
enum path_elt { path_mod(ident), path_name(ident) }
|
||||
type path = [path_elt];
|
||||
|
||||
/* FIXMEs that say "bad" are as per #2543 */
|
||||
fn path_to_str_with_sep(p: path, sep: str) -> str {
|
||||
let strs = vec::map(p) {|e|
|
||||
alt e {
|
||||
@ -291,6 +292,7 @@ fn node_id_to_str(map: map, id: node_id) -> str {
|
||||
#fmt["expr %s (id=%?)",
|
||||
pprust::expr_to_str(expr), id]
|
||||
}
|
||||
// FIXMEs are as per #2410
|
||||
some(node_export(_, path)) {
|
||||
#fmt["export %s (id=%?)", // FIXME: add more info here
|
||||
path_to_str(*path), id]
|
||||
|
@ -24,7 +24,7 @@ pure fn dummy_sp() -> span { ret mk_sp(0u, 0u); }
|
||||
pure fn path_name(p: @path) -> str { path_name_i(p.idents) }
|
||||
|
||||
pure fn path_name_i(idents: [ident]) -> str {
|
||||
// FIXME: Bad copies
|
||||
// FIXME: Bad copies (#2543 -- same for everything else that says "bad")
|
||||
str::connect(idents.map({|i|*i}), "::")
|
||||
}
|
||||
|
||||
|
@ -88,6 +88,7 @@ fn get_attr_name(attr: ast::attribute) -> ast::ident {
|
||||
get_meta_item_name(@attr.node.value)
|
||||
}
|
||||
|
||||
// All "bad" FIXME copies are as per #2543
|
||||
fn get_meta_item_name(meta: @ast::meta_item) -> ast::ident {
|
||||
alt meta.node {
|
||||
ast::meta_word(n) { /* FIXME bad */ copy n }
|
||||
@ -372,7 +373,7 @@ fn require_unique_names(diagnostic: span_handler,
|
||||
for metas.each {|meta|
|
||||
let name = get_meta_item_name(meta);
|
||||
|
||||
// FIXME: How do I silence the warnings? --pcw
|
||||
// FIXME: How do I silence the warnings? --pcw (#2619)
|
||||
if map.contains_key(*name) {
|
||||
diagnostic.span_fatal(meta.span,
|
||||
#fmt["duplicate meta item `%s`", *name]);
|
||||
|
Loading…
x
Reference in New Issue
Block a user