mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rollup merge of #90544 - ehuss:demote-locator-warn, r=petrochenkov

Browse Source 
Demote metadata load warning to "info".

There is a warn log message for whenever the crate loader fails to load metadata from a candidate file. I think this warning is too aggressive, as there are several situations where metadata information might not be found in a candidate file, which is normal. Also, this warning is somewhat confusing, and non-actionable in most cases for a user (most users will not know what it means).

If the crate loader ultimately does not find a valid crate, then an error will be reported (and hopefully #88368 will improve that error message).

If a rustc developer wants to debug a loader problem, they can still use `RUSTC_LOG=rustc_metadata=debug` and get the details.

There is more discussion of this particular warning at https://github.com/rust-lang/rust/issues/89795#issuecomment-940798190.

Fixes #90525
This commit is contained in:
Yuki Okushi 2021-11-05 10:32:44 +09:00 committed by GitHub
commit 6964ec2f72
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
compiler/rustc_metadata/src/locator.rs
View File

@ -236,7 +236,7 @@
use std::io::{Read, Result as IoResult, Write};
use std::path::{Path, PathBuf};
use std::{cmp, fmt, fs};
use tracing::{debug, info, warn};
use tracing::{debug, info};
#[derive(Clone)]
crate struct CrateLocator<'a> {
@ -549,7 +549,7 @@ fn extract_one(
}
}
Err(err) => {
warn!("no metadata found: {}", err);
info!("no metadata found: {}", err);
continue;
}
};