mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge #3432

Browse Source 
3432: Feature/snippet completions r=matklad a=iTZAvishay

This PR implements #1705 and is based on #3430 to avoid future conflicts.

The completions are placing default values with the names of the parameters, demo: 
![call_me_demo](https://user-images.githubusercontent.com/5567310/75828341-461ca400-5db4-11ea-88d8-88e59ac1a197.gif)


Co-authored-by: Avishay Matayev <me@avishay.dev>
This commit is contained in:
bors[bot] 2020-03-04 11:05:14 +00:00 committed by GitHub
commit 66ec6bdfb0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/ra_ide/src/completion/complete_scope.rs
View File

@ -38,7 +38,7 @@ mod tests {
label: "quux(…)",
source_range: [91; 91),
delete: [91; 91),
insert: "quux($0)",
insert: "quux(${1:x})$0",
kind: Function,
lookup: "quux",
detail: "fn quux(x: i32)",

34
crates/ra_ide/src/completion/presentation.rs
View File

@ -9,7 +9,7 @@ use crate::completion::{
CompletionContext, CompletionItem, CompletionItemKind, CompletionKind, Completions,
};
use crate::display::{const_label, function_label, macro_label, type_label};
use crate::display::{const_label, macro_label, type_label, FunctionSignature};
impl Completions {
pub(crate) fn add_field(
@ -198,7 +198,7 @@ impl Completions {
let name = name.unwrap_or_else(|| func.name(ctx.db).to_string());
let ast_node = func.source(ctx.db).value;
let detail = function_label(&ast_node);
let function_signature = FunctionSignature::from(&ast_node);
let mut builder =
CompletionItem::new(CompletionKind::Reference, ctx.source_range(), name.clone())
@ -209,7 +209,7 @@ impl Completions {
})
.set_documentation(func.docs(ctx.db))
.set_deprecated(is_deprecated(func, ctx.db))
.detail(detail);
.detail(function_signature.to_string());
// Add `<>` for generic types
if ctx.use_item_syntax.is_none()
@ -217,11 +217,19 @@ impl Completions {
&& ctx.db.feature_flags.get("completion.insertion.add-call-parenthesis")
{
tested_by!(inserts_parens_for_function_calls);
let (snippet, label) = if params.is_empty() || has_self_param && params.len() == 1 {
(format!("{}()$0", name), format!("{}()", name))
} else {
(format!("{}($0)", name), format!("{}(…)", name))
};
let (snippet, label) =
if params.is_empty() || has_self_param && params.len() == 1 {
(format!("{}()$0", name), format!("{}()", name))
} else {
let function_params_snippet =
join(function_signature.parameter_names.iter().enumerate().map(
|(index, param_name)| format!("${{{}:{}}}", index + 1, param_name),
))
.separator(", ")
.to_string();
(format!("{}({})$0", name, function_params_snippet), format!("{}(…)", name))
};
builder = builder.lookup_by(name).label(label).insert_snippet(snippet);
}
@ -486,7 +494,7 @@ mod tests {
label: "with_args(…)",
source_range: [80; 85),
delete: [80; 85),
insert: "with_args($0)",
insert: "with_args(${1:x}, ${2:y})$0",
kind: Function,
lookup: "with_args",
detail: "fn with_args(x: i32, y: String)",
@ -630,7 +638,7 @@ mod tests {
label: "foo(…)",
source_range: [61; 63),
delete: [61; 63),
insert: "foo($0)",
insert: "foo(${1:xs})$0",
kind: Function,
lookup: "foo",
detail: "fn foo(xs: Ve)",
@ -659,7 +667,7 @@ mod tests {
label: "foo(…)",
source_range: [64; 66),
delete: [64; 66),
insert: "foo($0)",
insert: "foo(${1:xs})$0",
kind: Function,
lookup: "foo",
detail: "fn foo(xs: Ve)",
@ -687,7 +695,7 @@ mod tests {
label: "foo(…)",
source_range: [68; 70),
delete: [68; 70),
insert: "foo($0)",
insert: "foo(${1:xs})$0",
kind: Function,
lookup: "foo",
detail: "fn foo(xs: Ve)",
@ -715,7 +723,7 @@ mod tests {
label: "foo(…)",
source_range: [61; 63),
delete: [61; 63),
insert: "foo($0)",
insert: "foo(${1:xs})$0",
kind: Function,
lookup: "foo",
detail: "fn foo(xs: Ve<i128>)",