mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

review comment: rename method

Browse Source
This commit is contained in:
Esteban Küber 2024-04-25 18:26:36 +00:00
parent abdb64d4ea
commit 64a4cdcfd4
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
compiler/rustc_borrowck/src/diagnostics/conflict_errors.rs
View File

@ -2120,7 +2120,7 @@ fn suggest_slice_method_if_applicable(
let hir::ExprKind::Index(_, idx1, _) = parent.kind else { return }; let hir::ExprKind::Index(_, idx1, _) = parent.kind else { return };
let hir::Node::Expr(parent) = tcx.parent_hir_node(index2.hir_id) else { return }; let hir::Node::Expr(parent) = tcx.parent_hir_node(index2.hir_id) else { return };
let hir::ExprKind::Index(_, idx2, _) = parent.kind else { return }; let hir::ExprKind::Index(_, idx2, _) = parent.kind else { return };
if !idx1.equals(idx2) { if !idx1.equivalent_for_indexing(idx2) {
err.help("use `.split_at_mut(position)` to obtain two mutable non-overlapping sub-slices"); err.help("use `.split_at_mut(position)` to obtain two mutable non-overlapping sub-slices");
} }
return; return;
@ -2146,7 +2146,7 @@ fn suggest_slice_method_if_applicable(
let Some(index2) = self.find_expr(issued_span) else { return }; let Some(index2) = self.find_expr(issued_span) else { return };
let hir::Node::Expr(parent) = tcx.parent_hir_node(index2.hir_id) else { return }; let hir::Node::Expr(parent) = tcx.parent_hir_node(index2.hir_id) else { return };
let hir::ExprKind::Index(_, idx2, _) = parent.kind else { return }; let hir::ExprKind::Index(_, idx2, _) = parent.kind else { return };
if idx1.equals(idx2) { if idx1.equivalent_for_indexing(idx2) {
// `let a = &mut foo[0]` and `let b = &mut foo[0]`? Don't mention `split_at_mut` // `let a = &mut foo[0]` and `let b = &mut foo[0]`? Don't mention `split_at_mut`
return; return;
} }

9
compiler/rustc_hir/src/hir.rs
View File

@ -1815,7 +1815,7 @@ pub fn is_approximately_pattern(&self) -> bool {
/// ///
/// This is only used for diagnostics to see if we have things like `foo[i]` where `foo` is /// This is only used for diagnostics to see if we have things like `foo[i]` where `foo` is
/// borrowed multiple times with `i`. /// borrowed multiple times with `i`.
pub fn equals(&self, other: &Expr<'_>) -> bool { pub fn equivalent_for_indexing(&self, other: &Expr<'_>) -> bool {
match (self.kind, other.kind) { match (self.kind, other.kind) {
(ExprKind::Lit(lit1), ExprKind::Lit(lit2)) => lit1.node == lit2.node, (ExprKind::Lit(lit1), ExprKind::Lit(lit2)) => lit1.node == lit2.node,
( (
@ -1837,11 +1837,14 @@ pub fn equals(&self, other: &Expr<'_>) -> bool {
| ( | (
ExprKind::Struct(QPath::LangItem(LangItem::RangeFrom, _), [val1], None), ExprKind::Struct(QPath::LangItem(LangItem::RangeFrom, _), [val1], None),
ExprKind::Struct(QPath::LangItem(LangItem::RangeFrom, _), [val2], None), ExprKind::Struct(QPath::LangItem(LangItem::RangeFrom, _), [val2], None),
) => val1.expr.equals(val2.expr), ) => val1.expr.equivalent_for_indexing(val2.expr),
( (
ExprKind::Struct(QPath::LangItem(LangItem::Range, _), [val1, val3], None), ExprKind::Struct(QPath::LangItem(LangItem::Range, _), [val1, val3], None),
ExprKind::Struct(QPath::LangItem(LangItem::Range, _), [val2, val4], None), ExprKind::Struct(QPath::LangItem(LangItem::Range, _), [val2, val4], None),
) => val1.expr.equals(val2.expr) && val3.expr.equals(val4.expr), ) => {
val1.expr.equivalent_for_indexing(val2.expr)
&& val3.expr.equivalent_for_indexing(val4.expr)
}
_ => false, _ => false,
} }
} }