mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rollup merge of #125346 - tbu-:pr_rm_path_to_str, r=wesleywiser

Browse Source 
Remove some `Path::to_str` from `rustc_codegen_llvm`

Unnecessary panic paths when there's a better option.
This commit is contained in:
Matthias Krüger 2024-05-21 00:47:04 +02:00 committed by GitHub
commit 63fa01eb09
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
compiler/rustc_codegen_llvm/src/back/archive.rs
View File

@ -200,21 +200,20 @@ impl ArchiveBuilderBuilder for LlvmArchiveBuilderBuilder {
_ => panic!("unsupported arch {}", sess.target.arch), _ => panic!("unsupported arch {}", sess.target.arch),
}; };
let mut dlltool_cmd = std::process::Command::new(&dlltool); let mut dlltool_cmd = std::process::Command::new(&dlltool);
dlltool_cmd.args([ dlltool_cmd
"-d", .arg("-d")
def_file_path.to_str().unwrap(), .arg(def_file_path)
"-D", .arg("-D")
lib_name, .arg(lib_name)
"-l", .arg("-l")
output_path.to_str().unwrap(), .arg(&output_path)
"-m", .arg("-m")
dlltool_target_arch, .arg(dlltool_target_arch)
"-f", .arg("-f")
dlltool_target_bitness, .arg(dlltool_target_bitness)
"--no-leading-underscore", .arg("--no-leading-underscore")
"--temp-prefix", .arg("--temp-prefix")
temp_prefix.to_str().unwrap(), .arg(temp_prefix);
]);
match dlltool_cmd.output() { match dlltool_cmd.output() {
Err(e) => { Err(e) => {