mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't fail changelog generation on missing PRs

Browse Source
This commit is contained in:
Laurențiu Nicola 2022-11-30 21:08:08 +02:00
parent 21b06c1beb
commit 60281a6135
1 changed files with 35 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
xtask/src/release/changelog.rs
View File

@ -30,34 +30,52 @@ pub(crate) fn get_changelog(
// we don't use an HTTPS client or JSON parser to keep the build times low // we don't use an HTTPS client or JSON parser to keep the build times low
let pr = pr_num.to_string(); let pr = pr_num.to_string();
let pr_json = let cmd = &cmd!(sh, "curl --fail -s -H {accept} -H {authorization} {pr_url}/{pr}");
cmd!(sh, "curl -s -H {accept} -H {authorization} {pr_url}/{pr}").read()?; let pr_json = match cmd.read() {
Ok(pr_json) => pr_json,
Err(e) => {
// most likely a rust-lang/rust PR
eprintln!("Cannot get info for #{pr}: {e}");
continue;
}
};
let pr_title = cmd!(sh, "jq .title").stdin(&pr_json).read()?; let pr_title = cmd!(sh, "jq .title").stdin(&pr_json).read()?;
let pr_title = unescape(&pr_title[1..pr_title.len() - 1]); let pr_title = unescape(&pr_title[1..pr_title.len() - 1]);
let pr_comment = cmd!(sh, "jq .body").stdin(pr_json).read()?; let pr_comment = cmd!(sh, "jq .body").stdin(pr_json).read()?;
let comments_json = let cmd =
cmd!(sh, "curl -s -H {accept} -H {authorization} {pr_url}/{pr}/comments").read()?; &cmd!(sh, "curl --fail -s -H {accept} -H {authorization} {pr_url}/{pr}/comments");
let pr_comments = cmd!(sh, "jq .[].body").stdin(comments_json).read()?; let pr_info = match cmd.read() {
Ok(comments_json) => {
let pr_comments = cmd!(sh, "jq .[].body").stdin(comments_json).read()?;
let l = iter::once(pr_comment.as_str()) iter::once(pr_comment.as_str())
.chain(pr_comments.lines()) .chain(pr_comments.lines())
.rev() .rev()
.find_map(|it| { .find_map(|it| {
let it = unescape(&it[1..it.len() - 1]); let it = unescape(&it[1..it.len() - 1]);
it.lines().find_map(parse_changelog_line) it.lines().find_map(parse_changelog_line)
}) })
.into_iter() .into_iter()
.next() .next()
.unwrap_or_else(|| parse_title_line(&pr_title)); }
let s = match l.kind { Err(e) => {
eprintln!("Cannot get comments for #{pr}: {e}");
None
}
};
let pr_info = pr_info.unwrap_or_else(|| parse_title_line(&pr_title));
let s = match pr_info.kind {
PrKind::Feature => &mut features, PrKind::Feature => &mut features,
PrKind::Fix => &mut fixes, PrKind::Fix => &mut fixes,
PrKind::Internal => &mut internal, PrKind::Internal => &mut internal,
PrKind::Other => &mut others, PrKind::Other => &mut others,
PrKind::Skip => continue, PrKind::Skip => continue,
}; };
writeln!(s, "* pr:{pr_num}[] {}", l.message.as_deref().unwrap_or(&pr_title)).unwrap(); writeln!(s, "* pr:{pr_num}[] {}", pr_info.message.as_deref().unwrap_or(&pr_title))
.unwrap();
} }
} }