mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add name in TODO

Browse Source
This commit is contained in:
Antoni Boucher 2022-07-06 23:05:14 -04:00
parent b14b440f3a
commit 5f4777e55d
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/attributes.rs
View File

@ -25,7 +25,7 @@ pub fn check_tied_features(sess: &Session, features: &FxHashMap<&str, bool>) ->
None None
} }
// TODO: maybe move to a new module gcc_util. // TODO(antoyo): maybe move to a new module gcc_util.
// To find a list of GCC's names, check https://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html // To find a list of GCC's names, check https://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html
fn to_gcc_features<'a>(sess: &Session, s: &'a str) -> SmallVec<[&'a str; 2]> { fn to_gcc_features<'a>(sess: &Session, s: &'a str) -> SmallVec<[&'a str; 2]> {
let arch = if sess.target.arch == "x86_64" { "x86" } else { &*sess.target.arch }; let arch = if sess.target.arch == "x86_64" { "x86" } else { &*sess.target.arch };
@ -95,7 +95,7 @@ pub fn from_fn_attrs<'gcc, 'tcx>(
.iter() .iter()
.flat_map(|feat| to_gcc_features(cx.tcx.sess, feat).into_iter()) .flat_map(|feat| to_gcc_features(cx.tcx.sess, feat).into_iter())
.chain(codegen_fn_attrs.instruction_set.iter().map(|x| match x { .chain(codegen_fn_attrs.instruction_set.iter().map(|x| match x {
InstructionSetAttr::ArmA32 => "-thumb-mode", // TODO: support removing feature. InstructionSetAttr::ArmA32 => "-thumb-mode", // TODO(antoyo): support removing feature.
InstructionSetAttr::ArmT32 => "thumb-mode", InstructionSetAttr::ArmT32 => "thumb-mode",
})) }))
.collect::<Vec<_>>(); .collect::<Vec<_>>();

2
src/common.rs
View File

@ -182,7 +182,7 @@ fn scalar_to_backend(&self, cv: Scalar, layout: abi::Scalar, ty: Type<'gcc>) ->
// NOTE: since the intrinsic _xabort is called with a bitcast, which // NOTE: since the intrinsic _xabort is called with a bitcast, which
// is non-const, but expects a constant, do a normal cast instead of a bitcast. // is non-const, but expects a constant, do a normal cast instead of a bitcast.
// FIXME(antoyo): fix bitcast to work in constant contexts. // FIXME(antoyo): fix bitcast to work in constant contexts.
// TODO: perhaps only use bitcast for pointers? // TODO(antoyo): perhaps only use bitcast for pointers?
self.context.new_cast(None, value, ty) self.context.new_cast(None, value, ty)
} }
else { else {

2
src/lib.rs
View File

@ -304,7 +304,7 @@ pub fn target_features(sess: &Session) -> Vec<Symbol> {
.filter(|_feature| { .filter(|_feature| {
// TODO(antoyo): implement a way to get enabled feature in libgccjit. // TODO(antoyo): implement a way to get enabled feature in libgccjit.
// Probably using the equivalent of __builtin_cpu_supports. // Probably using the equivalent of __builtin_cpu_supports.
// TODO: maybe use whatever outputs the following command: // TODO(antoyo): maybe use whatever outputs the following command:
// gcc -march=native -Q --help=target // gcc -march=native -Q --help=target
#[cfg(feature="master")] #[cfg(feature="master")]
{ {