mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Auto merge of #3071 - RalfJung:deprecate-disable-abi, r=oli-obk,saethlin

Browse Source 
deprecate -Zmiri-disable-abi-check

This was added in https://github.com/rust-lang/miri/pull/1776 but I couldn't find any discussion or motivation.
This commit is contained in:
bors 2023-09-21 15:40:16 +00:00
commit 5b8695b6bc
6 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/tools/miri/README.md
View File

@ -362,7 +362,7 @@ Some of these are **unsound**, which means they can lead
to Miri failing to detect cases of undefined behavior in a program. to Miri failing to detect cases of undefined behavior in a program.
* `-Zmiri-disable-abi-check` disables checking [function ABI]. Using this flag * `-Zmiri-disable-abi-check` disables checking [function ABI]. Using this flag
is **unsound**. is **unsound**. This flag is **deprecated**.
* `-Zmiri-disable-alignment-check` disables checking pointer alignment, so you * `-Zmiri-disable-alignment-check` disables checking pointer alignment, so you
can focus on other failures, but it means Miri can miss bugs in your program. can focus on other failures, but it means Miri can miss bugs in your program.
Using this flag is **unsound**. Using this flag is **unsound**.

4
src/tools/miri/src/bin/miri.rs
View File

@ -358,6 +358,10 @@ fn main() {
since it is now enabled by default" since it is now enabled by default"
); );
} else if arg == "-Zmiri-disable-abi-check" { } else if arg == "-Zmiri-disable-abi-check" {
eprintln!(
"WARNING: the flag `-Zmiri-disable-abi-check` is deprecated and planned to be removed.\n\
If you have a use-case for it, please file an issue."
);
miri_config.check_abi = false; miri_config.check_abi = false;
} else if arg == "-Zmiri-disable-isolation" { } else if arg == "-Zmiri-disable-isolation" {
if matches!(isolation_enabled, Some(true)) { if matches!(isolation_enabled, Some(true)) {

2
src/tools/miri/tests/fail/concurrency/unwind_top_of_stack.stderr
View File

@ -1,3 +1,5 @@
WARNING: the flag `-Zmiri-disable-abi-check` is deprecated and planned to be removed.
If you have a use-case for it, please file an issue.
thread '<unnamed>' panicked at $DIR/unwind_top_of_stack.rs:LL:CC: thread '<unnamed>' panicked at $DIR/unwind_top_of_stack.rs:LL:CC:
explicit panic explicit panic
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

2
src/tools/miri/tests/fail/function_calls/exported_symbol_bad_unwind1.stderr
View File

@ -1,3 +1,5 @@
WARNING: the flag `-Zmiri-disable-abi-check` is deprecated and planned to be removed.
If you have a use-case for it, please file an issue.
thread 'main' panicked at $DIR/exported_symbol_bad_unwind1.rs:LL:CC: thread 'main' panicked at $DIR/exported_symbol_bad_unwind1.rs:LL:CC:
explicit panic explicit panic
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

2
src/tools/miri/tests/fail/panic/bad_miri_start_panic.stderr
View File

@ -1,3 +1,5 @@
WARNING: the flag `-Zmiri-disable-abi-check` is deprecated and planned to be removed.
If you have a use-case for it, please file an issue.
error: Undefined Behavior: unwinding past a stack frame that does not allow unwinding error: Undefined Behavior: unwinding past a stack frame that does not allow unwinding
--> $DIR/bad_miri_start_panic.rs:LL:CC --> $DIR/bad_miri_start_panic.rs:LL:CC
| |

2
src/tools/miri/tests/pass/function_calls/disable_abi_check.stderr Normal file
View File

@ -0,0 +1,2 @@
WARNING: the flag `-Zmiri-disable-abi-check` is deprecated and planned to be removed.
If you have a use-case for it, please file an issue.