diff --git a/crates/ra_syntax/src/validation/char.rs b/crates/ra_syntax/src/validation/char.rs index 10d3d1dec44..1d6fe883752 100644 --- a/crates/ra_syntax/src/validation/char.rs +++ b/crates/ra_syntax/src/validation/char.rs @@ -89,12 +89,17 @@ pub(super) fn is_ascii_escape(code: char) -> bool { fn validate_ascii_code_escape(text: &str, range: TextRange, errors: &mut Vec) { // An AsciiCodeEscape has 4 chars, example: `\xDD` - if text.len() < 4 { + if !text.is_ascii() { + // TODO: Give a more precise error message (say what the invalid character was) + errors.push(SyntaxError::new(AsciiCodeEscapeOutOfRange, range)); + } else if text.chars().count() < 4 { errors.push(SyntaxError::new(TooShortAsciiCodeEscape, range)); } else { - assert!( - text.chars().count() == 4, - "AsciiCodeEscape cannot be longer than 4 chars" + assert_eq!( + text.chars().count(), + 4, + "AsciiCodeEscape cannot be longer than 4 chars, but text '{}' is", + text, ); match u8::from_str_radix(&text[2..], 16) { diff --git a/crates/ra_syntax/tests/data/parser/fuzz-failures/0003.rs b/crates/ra_syntax/tests/data/parser/fuzz-failures/0003.rs new file mode 100644 index 00000000000..0f59c472269 --- /dev/null +++ b/crates/ra_syntax/tests/data/parser/fuzz-failures/0003.rs @@ -0,0 +1 @@ +if'\xɿ \ No newline at end of file