mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Auto merge of #8034 - togami2864:non-ascii-in-sigle-literal, r=llogiq

Browse Source 
Non ascii in sigle literal

fix: #8013
changelog: `non_ascii_literal` warn against non-ASCII within `char`, not just `strings`
This commit is contained in:
bors 2021-11-26 11:03:54 +00:00
commit 5a6169d7f6
3 changed files with 23 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clippy_lints/src/unicode.rs
View File

@ -28,7 +28,7 @@ declare_clippy_lint! {
declare_clippy_lint! { declare_clippy_lint! {
/// ### What it does /// ### What it does
/// Checks for non-ASCII characters in string literals. /// Checks for non-ASCII characters in string and char literals.
/// ///
/// ### Why is this bad? /// ### Why is this bad?
/// Yeah, we know, the 90's called and wanted their charset /// Yeah, we know, the 90's called and wanted their charset
@ -75,7 +75,7 @@ declare_lint_pass!(Unicode => [INVISIBLE_CHARACTERS, NON_ASCII_LITERAL, UNICODE_
impl LateLintPass<'_> for Unicode { impl LateLintPass<'_> for Unicode {
fn check_expr(&mut self, cx: &LateContext<'_>, expr: &'_ Expr<'_>) { fn check_expr(&mut self, cx: &LateContext<'_>, expr: &'_ Expr<'_>) {
if let ExprKind::Lit(ref lit) = expr.kind { if let ExprKind::Lit(ref lit) = expr.kind {
if let LitKind::Str(_, _) = lit.node { if let LitKind::Str(_, _) | LitKind::Char(_) = lit.node {
check_str(cx, lit.span, expr.hir_id); check_str(cx, lit.span, expr.hir_id);
} }
} }

8
tests/ui/unicode.rs
View File

@ -20,8 +20,16 @@ fn uni() {
print!("\u{DC}ben!"); // this is ok print!("\u{DC}ben!"); // this is ok
} }
// issue 8013
#[warn(clippy::non_ascii_literal)]
fn single_quote() {
const _EMPTY_BLOCK: char = '▱';
const _FULL_BLOCK: char = '▰';
}
fn main() { fn main() {
zero(); zero();
uni(); uni();
canon(); canon();
single_quote();
} }

14
tests/ui/unicode.stderr
View File

@ -34,5 +34,17 @@ LL | print!("Üben!");
| |
= note: `-D clippy::non-ascii-literal` implied by `-D warnings` = note: `-D clippy::non-ascii-literal` implied by `-D warnings`
error: aborting due to 5 previous errors error: literal non-ASCII character detected
--> $DIR/unicode.rs:26:32
|
LL | const _EMPTY_BLOCK: char = '▱';
| ^^^ help: consider replacing the string with: `'/u{25b1}'`
error: literal non-ASCII character detected
--> $DIR/unicode.rs:27:31
|
LL | const _FULL_BLOCK: char = '▰';
| ^^^ help: consider replacing the string with: `'/u{25b0}'`
error: aborting due to 7 previous errors