Disable unqualified assoc items completion for now
This commit is contained in:
parent
879432452d
commit
56a7d246d5
@ -536,6 +536,7 @@ fn main() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
|
#[ignore = "FIXME: non-trait assoc items completion is unsupported yet, see FIXME in the import_assets.rs for more details"]
|
||||||
fn associated_struct_const_unqualified() {
|
fn associated_struct_const_unqualified() {
|
||||||
check_assist(
|
check_assist(
|
||||||
qualify_path,
|
qualify_path,
|
||||||
|
@ -949,7 +949,7 @@ fn main() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn local_assoc_items_are_omitted() {
|
fn unqualified_assoc_items_are_omitted() {
|
||||||
check(
|
check(
|
||||||
r#"
|
r#"
|
||||||
mod something {
|
mod something {
|
||||||
|
@ -256,7 +256,14 @@ fn path_applicable_imports(
|
|||||||
sema,
|
sema,
|
||||||
current_crate,
|
current_crate,
|
||||||
path_candidate.name.clone(),
|
path_candidate.name.clone(),
|
||||||
// unqualified assoc items are not valid syntax
|
// FIXME: we could look up assoc items by the input and propose those in completion,
|
||||||
|
// but that requries more preparation first:
|
||||||
|
// * store non-trait assoc items in import_map to fully enable this lookup
|
||||||
|
// * ensure that does not degrade the performance (bencmark it)
|
||||||
|
// * write more logic to check for corresponding trait presence requirement (we're unable to flyimport multiple item right now)
|
||||||
|
// * improve the associated completion item matching and/or scoring to ensure no noisy completions appear
|
||||||
|
//
|
||||||
|
// see also an ignored test under FIXME comment in the qualify_path.rs module
|
||||||
AssocItemSearch::Exclude,
|
AssocItemSearch::Exclude,
|
||||||
Some(DEFAULT_QUERY_SEARCH_LIMIT),
|
Some(DEFAULT_QUERY_SEARCH_LIMIT),
|
||||||
)
|
)
|
||||||
|
Loading…
x
Reference in New Issue
Block a user