mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable unqualified assoc items completion for now

Browse Source
This commit is contained in:
Kirill Bulatov 2021-03-20 23:04:28 +02:00
parent 879432452d
commit 56a7d246d5
3 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
crates/ide_assists/src/handlers/qualify_path.rs
View File

@ -536,6 +536,7 @@ fn main() {
}
#[test]
#[ignore = "FIXME: non-trait assoc items completion is unsupported yet, see FIXME in the import_assets.rs for more details"]
fn associated_struct_const_unqualified() {
check_assist(
qualify_path,

2
crates/ide_completion/src/completions/flyimport.rs
View File

@ -949,7 +949,7 @@ fn main() {
}
#[test]
fn local_assoc_items_are_omitted() {
fn unqualified_assoc_items_are_omitted() {
check(
r#"
mod something {

9
crates/ide_db/src/helpers/import_assets.rs
View File

@ -256,7 +256,14 @@ fn path_applicable_imports(
sema,
current_crate,
path_candidate.name.clone(),
// unqualified assoc items are not valid syntax
// FIXME: we could look up assoc items by the input and propose those in completion,
// but that requries more preparation first:
// * store non-trait assoc items in import_map to fully enable this lookup
// * ensure that does not degrade the performance (bencmark it)
// * write more logic to check for corresponding trait presence requirement (we're unable to flyimport multiple item right now)
// * improve the associated completion item matching and/or scoring to ensure no noisy completions appear
//
// see also an ignored test under FIXME comment in the qualify_path.rs module
AssocItemSearch::Exclude,
Some(DEFAULT_QUERY_SEARCH_LIMIT),
)